[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[task #15109] Arithmetic not reading data when metadata requested
From: |
Mohammad Akhlaghi |
Subject: |
[task #15109] Arithmetic not reading data when metadata requested |
Date: |
Sun, 8 Mar 2020 10:20:56 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0 |
Update of task #15109 (project gnuastro):
Summary: Size of dataset as an Arithmetic operator =>
Arithmetic not reading data when metadata requested
_______________________________________________________
Follow-up Comment #17:
Great! your commit
<http://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=4068336> is now in
the Gnuastro's main `master' branch. Some further corrections were necessary,
which I implemented in the next commit
<http://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=ddcb77a760>. Please
go through those points and look at the corrected lines to hopefully prepare
you for your next edits in the code ;-).
But as you may have noticed, I just changed the task summary/title, I didn't
close it. The reason is that we still need to read-in the full dataset to just
read its size. However, as mentioned in the first comment of this task, we
don't want this: when only the dataset's metadata is necessary, we shouldn't
read the data (and waste time and memory). So to complete this task, we should
add some special steps in the arithmetic program so when meta-data are
necessary, it doesn't go reading-in the full dataset. For example a special
variable/flag called `meta' can be defined in the relevant functions. The
`size' operator (or other later operators) will set it to 1, while the others
will set it to zero. When its 1, then the step where we pop the operator
(either read it, or just pick it from the stack), we just read/copy the
metadata in an empty-of-data dataset.
But this may be a little too low level for you Sachin and isn't a critical
issue now. So I recommend moving onto another task/bug. Thanks again for the
good work ;-).
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/task/?15109>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [task #15109] Size of dataset as an Arithmetic operator, Sachin Kumar Singh, 2020/03/04
- [task #15109] Size of dataset as an Arithmetic operator, Mohammad Akhlaghi, 2020/03/05
- [task #15109] Size of dataset as an Arithmetic operator, Mohammad Akhlaghi, 2020/03/05
- [task #15109] Size of dataset as an Arithmetic operator, Sachin Kumar Singh, 2020/03/06
- Message not available
- [task #15109] Size of dataset as an Arithmetic operator, Mohammad Akhlaghi, 2020/03/06
- [task #15109] Size of dataset as an Arithmetic operator, Sachin Kumar Singh, 2020/03/07
- [task #15109] Size of dataset as an Arithmetic operator, Mohammad Akhlaghi, 2020/03/07
- [task #15109] Size of dataset as an Arithmetic operator, Mohammad Akhlaghi, 2020/03/07
- [task #15109] Size of dataset as an Arithmetic operator, Sachin Kumar Singh, 2020/03/08
- [task #15109] Arithmetic not reading data when metadata requested,
Mohammad Akhlaghi <=