[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[task #15567] Converting hh:mm:ss and dd:mm:ss notations to degrees and

From: Mohammad Akhlaghi
Subject: [task #15567] Converting hh:mm:ss and dd:mm:ss notations to degrees and vice vesa
Date: Sat, 14 Mar 2020 17:41:36 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Follow-up Comment #8, task #15567 (project gnuastro):

Thanks Katrik. I see so many tests have been added.

To test it independently, I had to remove the `config.h' part and also add a
`main' function: 

  char *test="2:30:20";
  printf("%f\n", gal_units_convert_ra_decimal(test));
  printf("%f\n", gal_units_convert_dec_decimal(test));

I then gave the first random number that occurred to me: `2:30:20', but I got
the `Invalid length' error! I then changed it to `02:30:20' and got that error

Generally, this type of error checking on the raw string, and manually
checking every number (with the `strtod (copy + 1, &copy)' part) is not good
practice: it can hide many bugs.

What I recommend is to use the C library's `strok' function (for GNU C
Library, its explained under the Finding tokens in a string
section). You can call it in a loop (so all the values are checked in one
piece of code). You can specify the delimiter with `strtok' to be `:'.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]