[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[task #13658] Work on concave polygons too

From: Mohammad Akhlaghi
Subject: [task #13658] Work on concave polygons too
Date: Sat, 21 Mar 2020 18:12:24 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Update of task #13658 (project gnuastro):

        Percent Complete:                      0% => 70%                    
             Assigned to:                    None => sks_15                 


Follow-up Comment #30:

It has been merged with the master branch and pushed
<> to them
main repository :-).

After inspecting your commit, I done some modifications
<> to
make it blend in better. Then I improved the documentation
<> and
finally added a new option in Crop
<> to use
these new functions.

Please have a look at the commit messages and the corresponding updates in the
code, so we can hopefully have a smoother merge in the future.

I also noticed that you hadn't pulled the updates in the `master' branch
before you do the rebase. So a parallel branch was created. This is fine, but
generally, when you do a rebase, its best to first do a `git pull' on the
master branch to import all recent commits, then rebase it ;-).

With the new `--polygonnosort' option that was just added, Crop can indeed
work on Concave polygons, but generally, let's complete task #15578, and also
this task (the sorting f concave polygon vertices), then close bug #50120. 

Indeed, please mention all those tasks and bugs in your proposal, they are
directly related ;-).


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]