Re: [PATCH v1 00/15] Various fixes (mostly build related) and improvements.

[Adrien 'neox' Bourmault]

Le lundi 23 septembre 2024 à 16:42 +0200, Denis 'GNUtoo' Carikli a écrit :
> Hi,
Hi!

> 
> This patch set contains several fixes for the build:
> 
> * We have a reproducibility issues inside the tests that makes the
>   build fails. It wasn't found before because while tests were done at
>   different time, the FAT filesystem also encodes the access date but
>   no access time. This is now fixed along other issues found during
>   the debugging.
> 
> * It also takes care of removing the dependency on qemu-img that
>   wasn't mentionned anywhere (we use Guix to do that), makes sure that
>   unifont is detected on Trisquel 11, fixes the case where pandoc is
>   already installed, fixes the trisquel dependency script when the
>   computer is in French, all that without breaking Trisquel 10 (I also
>   tested the changes on Trisquel 10 and doesn't seems to cause any
>   issues).
> 
> As usual it also contains patches that add missing copyright
> information.
> 
> Important improvements
> ======================
> Beside that it also contain very important changes that are meant to
> simplify the documentation for users:
> 
> * We now only have 2 payloads per "computer" (x200_8mb and x200_16mb
>   are two different computers here): SeaBIOS and GRUB. The GRUB images
>   boots to GRUB directly without going through SeaBIOS but the code
>   that enables to boot to SeaBIOS and then directly to GRUB without
>   any ability to use SeaBIOS to boot something else has been kept in
>   case we need to do some workaround (though I'd prefer to avoid this
>   situation and collaborate with GRUB to fix issues instead).
> 
> * The images were also renamed. So in practice if we have a ThinkPad
>   X200 with a 8MiB flash and want to use an usqwerty keyboard we end
>   up with 4 images to choose from:
>   * grub_x200_8mb_corebootfb_usqwerty.rom
>   * seabios_x200_8mb_corebootfb_usqwerty.rom
>   * grub_x200_8mb_txtmode_usqwerty.rom
>   * seabios_x200_8mb_txtmode_usqwerty.rom
> 
> This is much easier to explain than what we had before. Since in the
> long run we are also working on making it easier to build GNU Boot
> (neox is for instance working on building Coreboot with Guix), we
> could also ask contributors to build different variant to help the
> project with debuging issues if necessary, or somehow provide the
> binaries ourselves on the alpha gnu ftp (alpha.gnu.org), as this is
> now safe to do since we generate all the corresponding source code
> when building.
> 
> Denis 'GNUtoo' Carikli (15):
>   guix: gnuboot-trisquel-preseed.img: enable to disable tests.
>   guix: gnuboot-trisquel-preseed.img: Make it reproducible.
>   guix: gnuboot-trisquel-preseed.img: add missing inputs.
>   guix: gnuboot-trisquel-grub.img: add missing inputs.
>   packages: roms: download: fix missing qemu-img.
>   website: pages: global.css: Add copyright header.
>   website: history: copyright: add reviewed website/pages/global.css
>     file.
>   Remove images with the seabios_grubfirst main payload.
>   rename seabios_withgrub images to seabios.
>   images: remove 'libgfxinit' from the image names.
>   dependencies: Trisquel 10: Add copyright header.
>   website: history: copyright: add verified
>     resources/dependencies/trisquel-10 file.
>   dependencies: Trisquel 10: Fix script for non-english locales.
>   dependencies: Trisquel 10: fix pandoc install.
>   dependencies: Trisquel: Add 'unifont' for Trisquel 11.


Thanks a lot for your work, especially for the great level of details you
provided on commits related to Trisquel preseed, which helped the review a
lot. 

This patchset has been merged and pushed to the main branch.
-- 
Adrien Bourmault
Maintainer, GNU Boot project
Associate member, Free Software Foundation
GPG : E23C26A5DEEEC5FA9CDDD57A57BC26A3687116F6

signature.asc
Description: This is a digitally signed message part