[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnucap-devel] ELEMENT interface question

From: al davis
Subject: Re: [Gnucap-devel] ELEMENT interface question
Date: Tue, 20 Nov 2012 16:05:57 -0500
User-agent: KMail/1.13.5 (Linux/2.6.32-5-amd64; KDE/4.4.5; x86_64; ; )

On Tuesday 20 November 2012, Felix Salfelder wrote:
> when implementing the filters i must have missed that
> COMMON_COMPONENT::tr_{accept,review}(COMPONENT*) are not
> const. as it seems, the COMMON_COMPONENT is intended to be
> abused for device states (in that case it's no longer
> 'common').

No.  commons must not store device states.

those functions should be const.

Thanks for the report, from now on they are.

The change must be propagated to anything derived from 
COMMON_COMPONENT, including bm_pwl 160-163 where "iterator" 
changes to "const_iterator".

When you see things like this, most likely it is a remnant of 
something from the past, or something that is not quite what it 
should be.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]