Re: [gnugo-devel] trevor_1_20.5

[Trevor Morris]

>Comments to the patch:
>> +Pattern EB25
>> +# tm New Pattern (3.1.20)
>> +
>> +O!.  cutable kiema on edge.
>> +.!O
>> +.!.
>> +---
>> +
>> +:8,B
>> +
>> +Obc
>> +daf
>> +.!.
>> +---
>> +
>> +; xplay_defend_both(a,b,c,a,c) ||
>> +; xplay_defend_both(b,a,d,b,d)
>
>This constraint looks wrong. Surely the xplay_defend_both calls should
>be xplay_attack_either since O is in turn to play after the 3 moves?
Yes, of course.

>
>> +# tm modified (3.1.20)
>> +#   FIXME: Should dragons be connectable via ko?
>> +#   see trevord:260
>
>Probably not. It seems likely that having them separate will give the
>best valuation.
>
>> -Obc
>> -daf
>> +Gbc
>> +daF
>>  ooo
>>  
>> -;xplay_attack_either(a,b,c,a,c) && xplay_attack_either(b,a,d,b,d)
>> +; xplay_attack_either(a,b,c,a,c) == WIN && 
>> +; xplay_attack_either(b,a,d,b,d) == WIN
>
>Why the new label G which isn't used? Why upper case F and G labels?
>The usual convention is that X stones in the pattern get upper case
>labels while O stones and empty vertices get lower case labels.

This upper/lower case convention does seem to be used consistently.
This case, for example, the letters flip between X & O, depending
on the attack order.

These labels were left over from some debugging that I was doing,
and aren't necessary.