Re: [gnugo-devel] NNGS crash

[Evan Berggren Daniel]

Attached is a simple fix.

There is a comment that says that in some rare cases, do_atari_atari finds
an attack but no defense, and that we assume the attack is illusory.  This
is one of them.  However, we only check for this after the first time we
call the function, and then we call it again with different depth
settings.  This patch adds the check there.

Thanks

Evan Daniel

Index: engine/combination.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/combination.c,v
retrieving revision 1.38
diff -u -r1.38 combination.c
--- engine/combination.c        20 Oct 2002 10:40:45 -0000      1.38
+++ engine/combination.c        1 Nov 2002 06:04:07 -0000
@@ -428,6 +428,10 @@
    */
   compute_aa_status(other, NULL);
   compute_aa_values(other);
+  if (aa_val == 0 || defense_point == NO_MOVE) {
+    /*same as above*/
+    return 0;
+  }
   aa_val = do_atari_atari(other, NULL, NULL, NULL, NO_MOVE, 0, 0, NULL);
   if (after_aa_val - aa_val > 0) {
     if (defense)



On Thu, 31 Oct 2002, Gunnar Farneback wrote:

> The appended game caused a crash on NNGS and reproducibly gives an
> assertion failure in blunder_size() when loaded. I suspect it has
> something to do with my last atari_atari changes but I don't have time
> to investigate it anytime soon.
>
> /Gunnar
>
> (;GM[1]FF[4]
> SZ[19]HA[9]KM[0.5]
> PW[hcg]WR[6k]
> PB[GnuGo (GNU Go 3.3.11)]BR[11k*]
> PC[NNGS]DT[2002-10-31]AP[gnugoclient:2.0]
> AB[dd][jd][pd][dj][jj][pj][dp][jp][pp]
> ;W[cp];B[co];W[dq];B[ep];W[eq];B[cq];W[bp];B[cr];W[fp];B[bo];W[fq]
> ;B[hq];W[fn];B[mp];W[qq];B[pq];W[qp];B[qo];W[po];B[ro];W[pr];B[or]
> ;W[oq];B[op];W[oo];B[np];W[qr];B[pm];W[rp];B[sp];W[qn];B[rn];W[qm]
> ;B[rm];W[ql];B[rl];W[qk];B[pn];W[nn];B[om];W[nm];B[on];W[no];B[pk]
> ;W[qj];B[qi];W[ri];B[qh];W[rh];B[pl];W[rj];B[ln];W[sq];B[rr];W[rq]
> ;B[ps];W[qs];B[oh];W[lm];B[km];W[rg];B[kl];W[mk];B[lj];W[oi];B[pi]
> ;W[ni];B[nh];W[mi];B[re];W[mh];B[mj];W[nj];B[mg];W[lg];B[nl]C[L:9]
> ;W[nk];B[ml]C[L:10];W[lk];B[mf];W[ll];B[mm];W[kj];B[kf];W[kn];B[jk]
> ;W[lo];B[mn]C[L:9];W[mo];B[ol]C[L:10];W[jo];B[lp];W[ko];B[ki];W[li]
> ;B[lf];W[kh];B[kp];W[io];B[ji];W[jh];B[ih];W[ig];B[hg];W[ii];B[hh]
> ;W[ij];B[hk];W[ik];B[il];W[jl];B[jm];W[ip];B[iq];W[os];B[go];W[hn]
> C[Program crashed.
> game adjourned])
>
>
> _______________________________________________
> gnugo-devel mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/gnugo-devel
>