[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnugo-devel] resign_3_17.1

From: Gunnar Farneback
Subject: Re: [gnugo-devel] resign_3_17.1
Date: Tue, 18 Feb 2003 21:54:14 +0100
User-agent: EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/20.7 (sparc-sun-solaris2.7) (with unibyte mode)

Dan wrote:
> It moves the function dragon_weak to utils.c

The dragon_weak() function only consults dragon data. To me it seems
very naturally placed in dragon.c.

Arend wrote:
> I had just put a patch together to fix this differently. IMO, all the
> gtp_...() functions in play_gtp.c should have "const char *s" as
> argument.

What problem would this solve?

I'm reluctant to add const here. I don't see any need to stop
functions from modifying the string or having to fuzz around if they
want to process the string with non-const library functions.

> That's how they are used (except in play_black() and play_white()),
> and gtp.c shouldn't have to worry about the command string possibly
> getting changed on the callback.

gtp.c couldn't care less if the string was changed. It's not worried
at all.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]