Re: [gnugo-devel] crash in twogtp

[Evan Berggren Daniel]

On Thu, 10 Jul 2003, Gunnar Farneback wrote:

> After some discussions on NNGS Evan has found the source of this
> problem and will send in a patch.

here it is; twogtp now works on my computer, running perl 5.8.0 (from
Debian unstable).  Can anyone running other versions of perl test this?

Thanks

Evan Daniel

--- interface/gtp_examples/twogtp       15 Feb 2003 14:32:54 -0000      1.9
+++ interface/gtp_examples/twogtp       10 Jul 2003 02:12:07 -0000
@@ -100,7 +100,7 @@
     my $self = shift;
     my $cmd = shift;

-    my $pid = open2(${$self->out}, ${$self->in}, $cmd);
+    my $pid = open2($self->{out}, $self->{in}, $cmd);
     return $pid;
 }

@@ -116,35 +116,35 @@
     } else {
        die "Illegal color $color\n";
     }
-    my $move = GTP::exec_cmd(${$self->in}, ${$self->out}, $cmd);
+    my $move = GTP::exec_cmd($self->{in}, $self->{out}, $cmd);
 }

 sub black {
     my $self = shift;
     my $move = shift;

-    GTP::exec_cmd(${$self->in}, ${$self->out}, "black $move");
+    GTP::exec_cmd($self->{in}, $self->{out}, "black $move");
 }

 sub white {
     my $self = shift;
     my $move = shift;

-    GTP::exec_cmd(${$self->in}, ${$self->out}, "white $move");
+    GTP::exec_cmd($self->{in}, $self->{out}, "white $move");
 }

 sub komi {
     my $self = shift;
     my $komi = shift;

-    GTP::exec_cmd(${$self->in}, ${$self->out}, "komi $komi");
+    GTP::exec_cmd($self->{in}, $self->{out}, "komi $komi");
 }

 sub boardsize {
     my $self = shift;
     my $size = shift;

-    GTP::exec_cmd(${$self->in}, ${$self->out}, "boardsize $size");
+    GTP::exec_cmd($self->{in}, $self->{out}, "boardsize $size");
 }

 sub handicap {
@@ -152,7 +152,7 @@
     my $handicap = shift;

     my $stones;
-    $stones = GTP::exec_cmd(${$self->in}, ${$self->out}, "handicap $handicap");
+    $stones = GTP::exec_cmd($self->{in}, $self->{out}, "handicap $handicap");
     return split(' ', $stones);
 }

@@ -161,7 +161,7 @@
     my $handicap = shift;

     my $stones;
-    $stones = GTP::exec_cmd(${$self->in}, ${$self->out}, "fixed_handicap 
$handicap");
+    $stones = GTP::exec_cmd($self->{in}, $self->{out}, "fixed_handicap 
$handicap");
     return split(' ', $stones);
 }

@@ -174,13 +174,13 @@
 sub showboard {
     my $self = shift;

-    GTP::exec_cmd(${$self->in}, ${$self->out}, "showboard");
+    GTP::exec_cmd($self->{in}, $self->{out}, "showboard");
 }

 sub get_random_seed {
     my $self = shift;

-    my $ret = GTP::exec_cmd(${$self->in}, ${$self->out}, "get_random_seed");
+    my $ret = GTP::exec_cmd($self->{in}, $self->{out}, "get_random_seed");
     if ($ret eq "ERROR") {
         return "unknown";
     }
@@ -191,21 +191,21 @@
 sub get_program_name {
     my $self = shift;

-    my $name = GTP::exec_cmd(${$self->in}, ${$self->out}, "name");
-    my $version = GTP::exec_cmd(${$self->in}, ${$self->out}, "version");
+    my $name = GTP::exec_cmd($self->{in}, $self->{out}, "name");
+    my $version = GTP::exec_cmd($self->{in}, $self->{out}, "version");
     return "$name $version";
 }

 sub score {
     my $self = shift;

-    return GTP::exec_cmd(${$self->in}, ${$self->out}, "score");
+    return GTP::exec_cmd($self->{in}, $self->{out}, "score");
 }

 sub estimate_score {
     my $self = shift;

-    my $ret = GTP::exec_cmd(${$self->in}, ${$self->out}, "estimate_score");
+    my $ret = GTP::exec_cmd($self->{in}, $self->{out}, "estimate_score");
     my ($result, $rest) = split(' ', $ret, 2);
     return $result;
 }