Re: [gnugo-devel] Re: Code removal (#25) (reorientation code)

[Gunnar Farnebäck]

Arend wrote:
> Let me just say that I am not convinced by any of the reasons you give,
> but that I think I have given this enough of a push and will let it
> rest, unless somoene else wants to pursue this further.

There's at least no need to support orientation outside of GTP mode.
That let's us get rid of the rotate calls related to the --decide_*
options, which anyway were only half effective since the output moves
were never rotated back.

/Gunnar

Index: interface/main.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/main.c,v
retrieving revision 1.105
diff -u -r1.105 main.c
--- interface/main.c    9 Nov 2004 00:45:36 -0000       1.105
+++ interface/main.c    6 Oct 2005 17:36:32 -0000
@@ -857,7 +857,6 @@
            fprintf(stderr, "gnugo: use --limit-search <pos>\n");
            return EXIT_FAILURE;
          }
-         rotate(m, n, &m, &n, board_size, orientation);
          set_search_diamond(POS(m, n));
        }
        break;
@@ -1160,7 +1159,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(m, n, &m, &n, board_size, orientation);
       decide_string(POS(m, n));
     }
     break;
@@ -1186,8 +1184,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(ai, aj, &ai, &aj, board_size, orientation);
-      rotate(bi, bj, &bi, &bj, board_size, orientation);
       decide_connection(POS(ai, aj), POS(bi, bj));
     }
     break;
@@ -1206,7 +1202,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(m, n, &m, &n, board_size, orientation);
       decide_owl(POS(m, n));
     }
     break;
@@ -1225,7 +1220,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(m, n, &m, &n, board_size, orientation);
       decide_dragon_data(POS(m, n));
     }
     break;
@@ -1251,8 +1245,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(ai, aj, &ai, &aj, board_size, orientation);
-      rotate(bi, bj, &bi, &bj, board_size, orientation);
       decide_semeai(POS(ai, aj), POS(bi, bj));
     }
     break;
@@ -1279,8 +1271,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(ai, aj, &ai, &aj, board_size, orientation);
-      rotate(bi, bj, &bi, &bj, board_size, orientation);
       decide_tactical_semeai(POS(ai, aj), POS(bi, bj));
     }
     break;
@@ -1314,7 +1304,6 @@
        return EXIT_FAILURE;
       }
       
-      rotate(m, n, &m, &n, board_size, orientation);
       decide_eye(POS(m, n));
     }
     break;
@@ -1343,7 +1332,6 @@
        return EXIT_FAILURE;
       }
 
-      rotate(m, n, &m, &n, board_size, orientation);
       decide_surrounded(POS(m, n));
       break;
     }