[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: task 8800: Bug fix

From: Davi Leal
Subject: Re: task 8800: Bug fix
Date: Mon, 27 Oct 2008 23:47:28 +0100
User-agent: KMail/1.9.9

Federico Gimenez Nieto wrote:
> Check the attached patch, it sets the OfferDate field to the current
> date on each JobOffer update.

Your patch works.

> I have put the OfferDate field at the end of the field list in the query
> to avoid changing all the references to the other fields, perhaps it is
> better to put it beside the ExpirationDate field.

It was a good idea to reduce the patch impact.

The below line is not needed due to we can use the PostgreSQL 'now' expression 
instead, directly in the SQL sentence: J1_OfferDate='now'


So, as we do not add any new parameter we can add the OfferDate before the 
ExpirationDate field, instead of at the end of the field list.

If you do not disagree you can commit the last version of the patch. It is 
attached to this email.

Attachment: task-8800.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]