Re: [PATCH] Dropping ?> from end of files

[Davi Leal]

Amir M. Saied wrote:
> At the first try these files seem to make headers to be sent early.

It works!  Feel free to commit it.



Maybe this patch will allow reintegrate 'View_Photo_or_Logo.php' in the webapp 
architecture.

  Layer-0__Site_entry_point/View_Photo_or_Logo.php

I was forced to duplicate code to avoid use 'require_once', which was adding 
line breaks, and so breaking the image format which was downloaded.  We did 
not know about this ?> trick!


Maybe we could even revert the below lines at
  Layer-1__Page_builder/Web_Page.php

      ob_end_clean();
      ob_start();




--
Amir M. Saied wrote:
> We should really consider dropping php close tag from end of files
> because of they make headers to be sent earlier than when they are
> supposed to be sent.

Davi Leal wrote:
> In the current state, the webapp is already working.  Why do you
> think we should drop php close tags from end of files?  Would the
> webapp be quicker or something else?

Amir M. Saied wrote:
> No, it would make application warning-free. More standard I mean.
>
>    "PHP does not need closing tags, and omitting them will save
>     you from other problems, like trialing newline chars causing
>     headers to be sent."
>
> Check source files of Zend Framework for example, no file has a ?>
>
> Won't touch Smarty files unless they start throwing away warnings.