gnumed-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnumed-devel] Issues with 0.5 detected when trying to package


From: Andreas Tille
Subject: [Gnumed-devel] Issues with 0.5 detected when trying to package
Date: Sat, 15 Aug 2009 16:06:46 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

Hi,

when starting iwth the packaging work I detected two issues I want to
discuss:

1. gnumed-client.conf.example:

...
[profile public GNUmed database]
host = salaam.homeunix.com
port = 5432
database = gnumed_v10
                  ^^^

Shouldn't this be v11?

2. external-tools

   Karsten asked me to install /usr/bin/gm-install_arriba
   I will refuse to do so in the current state because this script
   is doing "dirty" things.

   1. INSTALL_BASE="/usr/bin" - no, I will *not* provide a script
      which moves any file not under control of the package manager
      to /usr/bin.  I can't avoid that admins do such things, but I
      will not tell them to do so.
      --> I would generally advise to use
        INSTALL_BASE="/usr/local/bin"
   2. The script would also require Java (well, not your installer
      script, but the jar you are installing.  So what is the sense
      to install a piece of software without ensuring that it will
      work.  This could be done with an extra Recommends / Suggests
      openjdk-6-jre (if the jar works with this).  But I would really
      hesitate to bloat gnumed-client dependencies to much.  So
      simply moving this gm-install_arriba to /usr/bin makes no
      sense.
   3. Guessing from the name the script is intended to be called
      only once (to install a piece of software.  IMHO the solution
      of choice (even if the two items above would not be valid)
      would be to move this to /usr/share/doc/examples or something
      like this.  Executables in /usr/bin need a valid man page
      as documentation - well I really think this script deserves
      documentation anyway - and you obviosely have refused to
      write such anyway.

  The other two downloaders: Please explain the sense of moving
  data to /tmp rather than to /var/lib/gnumed/(tmp).  The
  directory /tmp is removed after each boot process.  So what is
  the sense of these data and how are the scripts used?

Perhaps that's not all - but I just wanted to clarify this for the
moment.

Kind regards

    Andreas.

-- 
http://fam-tille.de
Klarmachen zum Ă„ndern!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]