Fixes: - xhtml fixes for search results, preferences - cosmetics in ChangeLog - don't offer to play play all preferences - default is to show all types of files Index: ChangeLog =================================================================== RCS file: /cvsroot/gnump3d/gnump3d/ChangeLog,v retrieving revision 1.42 diff -u -r1.42 ChangeLog --- ChangeLog 3 Nov 2003 09:18:56 -0000 1.42 +++ ChangeLog 3 Nov 2003 18:19:41 -0000 @@ -29,20 +29,22 @@ - THEMES: Corrected a couple of typos and HTML errors. - THEMES: Fixed obsolete references to /last/ - - BUGFIX: Don't escape the ':' character. (Broke banners). - - BUGFIX: Allow downsampling commands to work case insensitively of + - BUGFIX: Don't escape the ':' character. (Broke banners). + - BUGFIX: Allow downsampling commands to work case insensitively of filename suffix. - - BUGFIX: 'Random Selection' on the directory index links properly. + - BUGFIX: 'Random Selection' on the directory index links properly. - BUGFIX: Added several new test scripts. - BUGFIX: Advanced playlists contain the track lengths in seconds. - BUGFIX: gnump3d-index has a valid shebang line. - BUGFIX: Searching with no terms returns an error rather than all files. - BUGFIX: Searching on genre fixed. - BUGFIX: XHTML 1.0 output cleanups. + - BUGFIX: Default preference is to show all file types, not hide them. + - BUGFIX: Don't offer to play the prefs panel - - PLUGINS: preferences plugin shows installed languages. - (doesnt allow switching; wanna encourage more contributions) - - PLUGINS: Now possible to searching artist, album, or song title. + - PLUGINS: Preferences plugin shows installed languages. + (doesn't allow switching; wanna encourage more contributions) + - PLUGINS: Now possible to search on artist, album, or song title. Index: bin/gnump3d2 =================================================================== RCS file: /cvsroot/gnump3d/gnump3d/bin/gnump3d2,v retrieving revision 1.43 diff -u -r1.43 gnump3d2 --- bin/gnump3d2 2 Nov 2003 19:32:26 -0000 1.43 +++ bin/gnump3d2 3 Nov 2003 18:19:41 -0000 @@ -2505,12 +2505,15 @@ } } - # - # Interpolate links - chopping out trailing '/' if necessary. - # - $dir =~ s/(.*)\/?/$1/; - $dir = &urlEncode( $dir ); - $banner .= " | $play_rec ]"; + if ( $dir ne '/prefs/' ) { + # + # Interpolate links - chopping out trailing '/' if necessary. + # + $dir =~ s/(.*)\/?/$1/; + $dir = &urlEncode( $dir ); + $banner .= " | $play_rec"; + } + $banner .= " ]"; return( $banner ); } @@ -2709,6 +2712,7 @@ { my ( $prefix, $path ) = (@_); $path .= "/"; + $path =~ s|//|/|g; my @list = ""; while( $path =~ /(.*)\/(.*)/ ) Index: lib/gnump3d/plugins/prefs.pm =================================================================== RCS file: /cvsroot/gnump3d/gnump3d/lib/gnump3d/plugins/prefs.pm,v retrieving revision 1.4 diff -u -r1.4 prefs.pm --- lib/gnump3d/plugins/prefs.pm 29 Oct 2003 14:58:06 -0000 1.4 +++ lib/gnump3d/plugins/prefs.pm 3 Nov 2003 18:19:41 -0000 @@ -85,7 +85,7 @@ # -# Read and return the bug reporting form to the caller. +# Read and return the preferences form to the caller. sub getPrefsForm( $ ) { my ($theme) = (@_); @@ -258,38 +258,38 @@ } my $hideOgg = $ARGUMENTS{ "hideogg"}; - my $oggon = "checked"; - my $oggoff = ""; + my $oggon = ""; + my $oggoff = "checked='checked'"; if ( defined( $hideOgg ) ) { if ( $hideOgg ne 1 ) { $oggon = ""; - $oggoff = "checked"; + $oggoff = "checked='checked'"; } } my $hideMP3 = $ARGUMENTS{ "hidemp3"}; - my $mp3on = "checked"; - my $mp3off = ""; + my $mp3on = ""; + my $mp3off = "checked='checked'"; if ( defined( $hideMP3 ) ) { if ( $hideMP3 ne 1 ) { $mp3on = ""; - $mp3off = "checked"; + $mp3off = "checked='checked'"; } } my $hideMOV = $ARGUMENTS{ "hidemov"}; - my $movon = "checked"; - my $movoff = ""; + my $movon = ""; + my $movoff = "checked='checked'"; if ( defined( $hideMOV ) ) { if ( $hideMOV ne 1 ) { $movon = ""; - $movoff = "checked"; + $movoff = "checked='checked'"; } } @@ -302,12 +302,12 @@ Song Display: - - - - - - + + + + + +
Show Oggs Hide Oggs
Show MP3s Hide MP3s
Show Movies Hide Movies
Show Oggs Hide Oggs
Show MP3s Hide MP3s
Show Movies Hide Movies
@@ -327,7 +327,7 @@ next if ( $name =~ /^CVS$/ ); # - # Read the Author of the plugin if it's defined. + # Read the Author of the theme if it's defined. # if ( -e $theme_dir . "/" . $name . "/" . "AUTHOR" ) { @@ -342,18 +342,16 @@ if ( $ARGUMENTS{"theme"} eq $name ) { - $checked = "checked"; + $checked = "checked='checked'"; } - $text .= " $name $author
"; + $text .= " $name $author
"; } - $text .= "\n"; - $text .= "\n"; $text .=<  -\n +\n E_O_BUG3 $text .= $post; Index: lib/gnump3d/plugins/search.pm =================================================================== RCS file: /cvsroot/gnump3d/gnump3d/lib/gnump3d/plugins/search.pm,v retrieving revision 1.8 diff -u -r1.8 search.pm --- lib/gnump3d/plugins/search.pm 2 Nov 2003 19:15:07 -0000 1.8 +++ lib/gnump3d/plugins/search.pm 3 Nov 2003 18:19:41 -0000 @@ -391,6 +391,7 @@ $playAll .= "&play=1"; $playAll .= "&q=$terms"; $playAll = "/search" . $playAll ; + $playAll = gnump3d::url::encodeEntities( $playAll ); $total =~ s/\$PLAY_RESULTS/$playAll/g; Index: templates/default/recent.html =================================================================== RCS file: /cvsroot/gnump3d/gnump3d/templates/default/recent.html,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 recent.html --- templates/default/recent.html 28 Jul 2003 22:26:38 -0000 1.1.1.1 +++ templates/default/recent.html 3 Nov 2003 18:19:41 -0000 @@ -7,9 +7,9 @@ $BANNER

- +
- +

Most Recent Tracks

$TEXT Index: templates/default/results.html =================================================================== RCS file: /cvsroot/gnump3d/gnump3d/templates/default/results.html,v retrieving revision 1.2 diff -u -r1.2 results.html --- templates/default/results.html 2 Nov 2003 19:15:07 -0000 1.2 +++ templates/default/results.html 3 Nov 2003 18:19:41 -0000 @@ -19,8 +19,6 @@

 

- -
@@ -28,7 +26,6 @@
-