[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNUnet-developers] clang formatting discussion

From: ng0
Subject: Re: [GNUnet-developers] clang formatting discussion
Date: Thu, 18 Apr 2019 13:24:54 +0000

Christian Grothoff transcribed 4.3K bytes:
> On 4/18/19 12:40 PM, ng0 wrote:
> > Christian Grothoff transcribed 3.0K bytes:
> >> On 4/18/19 11:20 AM, ng0 wrote:
> >>>>> We can include an ASL2.0 (Apache-2.0 WITH LLVM-exception) file
> >>>>> in contrib right? As far as I remember asl2.0 is compatible to
> >>>>> newer gpl.
> >>>>> There's a diff reformater for clang-format.
> >>>> Not sure I follow. The clang-format config has an implicit license?
> >>> No, this is a different subject. clang-format-diff is a python script.
> >>> I lost the original URL (somewhere in LLVM), here it is in my repo:
> >>>
> >>
> >> On Debian, I have a clang-format-diff-8 that comes with the Debian
> >> package clang-format-8. So I don't think this truly belongs into our
> >> tree; this should simply be a regular external (optional,
> >> developer-only?) dependency (if we actually need it).
> >>
> > 
> > We could have it in there, similar to how I bundled checkbashism from
> > Debian as I don't expect everyone to have this available. Those are
> > small scripts. 
> Sure, but they still don't really belong into our development tree. That

Sorry, but no one was really bothered by the one python script we kept
in source for years. I added checkbashism as a convenience to not add
yet another dependency. I don't really need it (I have it out of tree).
You don't need to install it, as it is a perl script which depends on
nothing but itself, for systems outside of Debian you mostly cherry-pick
it from their sources. It's not available as a one-file thing.

> also goes for checkbashism. Just too much clutter. We should list those
> as optional dependencies *for developers* and devs can install them when
> needed. As long as we are not customizing/developing on that code, we
> should keep it outside of our tree, especially if it is available in
> Debian (and thus likely other distros) as a separate package already.

> _______________________________________________
> GNUnet-developers mailing list
> address@hidden

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]