[PATCH] Re: Question about GNS record representation in json

[fence]

So I've looked into the issue and fixed it.

The shadow flag wasn't parsed properly from JSON and it overwrote the 
"is_supplemental" flag when converting a record to JSON.

As for the rewrite, I don't have that much time on my hand right now.

kind regards,
fence


On 13.08.2024 13:24, Schanzenbach, Martin wrote:
> This may be a bug/oversight.
> The reason may be that shadow records must be ignored by the resolver 
> and are never returned as part of a resolution process.
>
> If you have any use or require a symmetric API, then this can be changed.
> Feel free to modify the code accordingly.
>
> Note that the REST service is in dire need of a rewrite (see https:// 
> www.gnunet.org/en/gsoc.html "Pluggable REST service components").
> So, if you have some spare time you can check that out as well :)
>
> BR
> Martin
>
> On 12.08.24 17:10, fence wrote:
> > Hewo,
> >
> > Is there a reason why GNUNET_JSON_GNSRECORD_FLAG_SHADOW is only 
> > deserialised but never serialised?
> >
> > Is that a bug or was the functionality removed and still being parsed 
> > in case an old client still sending the flag?
> >
> > kind regards,
> > fence

0001-lib-fix-gnsrecord-json-serialization.patch
Description: Text document