gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] r13770 - gnunet/src/core


From: gnunet
Subject: [GNUnet-SVN] r13770 - gnunet/src/core
Date: Mon, 22 Nov 2010 22:02:28 +0100

Author: grothoff
Date: 2010-11-22 22:02:28 +0100 (Mon, 22 Nov 2010)
New Revision: 13770

Modified:
   gnunet/src/core/core_api.c
Log:
clarifications on r13759

Modified: gnunet/src/core/core_api.c
===================================================================
--- gnunet/src/core/core_api.c  2010-11-22 20:59:13 UTC (rev 13769)
+++ gnunet/src/core/core_api.c  2010-11-22 21:02:28 UTC (rev 13770)
@@ -479,8 +479,6 @@
     {
       GNUNET_CLIENT_disconnect (h->client, GNUNET_NO);
       h->client = NULL;
-      /* FIXME: is this right? GNUNET_CLIENT_disconnect frees all outstanding 
transmission handles, so h->cth is invalid! */
-      /* Otherwise a subsequent call to GNUNET_CORE_disconnect tries to cancel 
this task!!! */
       h->cth = NULL;
       GNUNET_CONTAINER_multihashmap_iterate (h->peers,
                                             &disconnect_and_free_peer_entry,
@@ -1133,10 +1131,10 @@
                  "Received notification about transmission readiness to 
`%s'.\n",
                  GNUNET_i2s (&smr->peer));
 #endif
-      /* FIXME: pr->pending_head is sometimes NULL here... Safe to just 
return?  Or does this indicate something is out of sync somewhere else? */
       if (pr->pending_head == NULL)
         {
-          GNUNET_break (0);
+         /* request must have been cancelled between the origional request
+            and the response from core, ignore core's readiness */
           return;
         }
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]