[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] r24776 - gnunet/src/stream
From: |
gnunet |
Subject: |
[GNUnet-SVN] r24776 - gnunet/src/stream |
Date: |
Mon, 5 Nov 2012 20:05:49 +0100 |
Author: harsha
Date: 2012-11-05 20:05:49 +0100 (Mon, 05 Nov 2012)
New Revision: 24776
Modified:
gnunet/src/stream/stream_api.c
Log:
coverity fixes
Modified: gnunet/src/stream/stream_api.c
===================================================================
--- gnunet/src/stream/stream_api.c 2012-11-05 18:57:11 UTC (rev 24775)
+++ gnunet/src/stream/stream_api.c 2012-11-05 19:05:49 UTC (rev 24776)
@@ -877,10 +877,10 @@
}
}
/* Now send new packets if there is enough buffer space */
- while ( (NULL != io_handle->messages[packet]) &&
- (socket->receiver_window_available
- >= ntohs (io_handle->messages[packet]->header.header.size)) &&
- (packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH))
+ while ((packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH) &&
+ (NULL != io_handle->messages[packet]) &&
+ (socket->receiver_window_available
+ >= ntohs (io_handle->messages[packet]->header.header.size)))
{
socket->receiver_window_available -=
ntohs (io_handle->messages[packet]->header.header.size);
@@ -968,7 +968,10 @@
for (packet = 0; packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH; packet++)
{
if (socket->copy_offset == socket->receive_buffer_boundaries[packet])
- { packet++; break; }
+ {
+ packet++;
+ break;
+ }
if (socket->copy_offset < socket->receive_buffer_boundaries[packet])
break;
}
@@ -999,7 +1002,7 @@
/* Fix relative boundaries */
for (packet=0; packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH; packet++)
{
- if (packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH - sequence_increase)
+ if (packet < (GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH - sequence_increase))
{
uint32_t ahead_buffer_boundary;
@@ -1108,7 +1111,7 @@
expecting */
relative_sequence_number =
ntohl (msg->sequence_number) - socket->read_sequence_number;
- if ( relative_sequence_number > GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH)
+ if ( relative_sequence_number >= GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH)
{
LOG (GNUNET_ERROR_TYPE_DEBUG,
"%s: Ignoring received message with sequence number %u\n",
@@ -1490,6 +1493,7 @@
GNUNET_NO);
else
GNUNET_break (0);
+ break;
default:
GNUNET_break (0);
}
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [GNUnet-SVN] r24776 - gnunet/src/stream,
gnunet <=