[GNUnet-SVN] r36519 - gnunet/src/transport

[gnunet]

Author: grothoff
Date: 2015-10-17 21:34:43 +0200 (Sat, 17 Oct 2015)
New Revision: 36519

Modified:
   gnunet/src/transport/gnunet-service-transport_clients.c
   gnunet/src/transport/gnunet-service-transport_neighbours.c
   gnunet/src/transport/transport_api.c
Log:
-be harsher about transport service sending messages out of line, also at the 
same time check in transport service to only transmit messages if in the right 
state

Modified: gnunet/src/transport/gnunet-service-transport_clients.c
===================================================================
--- gnunet/src/transport/gnunet-service-transport_clients.c     2015-10-17 
19:02:04 UTC (rev 36518)
+++ gnunet/src/transport/gnunet-service-transport_clients.c     2015-10-17 
19:34:43 UTC (rev 36519)
@@ -709,15 +709,19 @@
   struct SendTransmitContinuationContext *stcc = cls;
   struct SendOkMessage send_ok_msg;
 
-  send_ok_msg.header.size = htons (sizeof (send_ok_msg));
-  send_ok_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SEND_OK);
-  send_ok_msg.bytes_msg = htonl (bytes_payload);
-  send_ok_msg.bytes_physical = htonl (bytes_on_wire);
-  send_ok_msg.success = htonl (success);
-  send_ok_msg.peer = stcc->target;
-  GST_clients_unicast (stcc->client,
-                       &send_ok_msg.header,
-                       GNUNET_NO);
+  if (GST_neighbours_test_connected (&stcc->target))
+  {
+    /* Only send confirmation if we are still connected */
+    send_ok_msg.header.size = htons (sizeof (send_ok_msg));
+    send_ok_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SEND_OK);
+    send_ok_msg.bytes_msg = htonl (bytes_payload);
+    send_ok_msg.bytes_physical = htonl (bytes_on_wire);
+    send_ok_msg.success = htonl (success);
+    send_ok_msg.peer = stcc->target;
+    GST_clients_unicast (stcc->client,
+                         &send_ok_msg.header,
+                         GNUNET_NO);
+  }
   GNUNET_SERVER_client_drop (stcc->client);
   GNUNET_free (stcc);
 }

Modified: gnunet/src/transport/gnunet-service-transport_neighbours.c
===================================================================
--- gnunet/src/transport/gnunet-service-transport_neighbours.c  2015-10-17 
19:02:04 UTC (rev 36518)
+++ gnunet/src/transport/gnunet-service-transport_neighbours.c  2015-10-17 
19:34:43 UTC (rev 36519)
@@ -559,28 +559,32 @@
 /**
  * Notify our clients that another peer connected to us.
  *
- * @param peer the peer that connected
- * @param bandwidth_in inbound bandwidth in NBO
- * @param bandwidth_out outbound bandwidth in NBO
+ * @param n the peer that connected
  */
 static void
-neighbours_connect_notification (const struct GNUNET_PeerIdentity *peer,
-                                 struct GNUNET_BANDWIDTH_Value32NBO 
bandwidth_in,
-                                 struct GNUNET_BANDWIDTH_Value32NBO 
bandwidth_out)
+neighbours_connect_notification (struct NeighbourMapEntry *n)
 {
   size_t len = sizeof(struct ConnectInfoMessage);
   char buf[len] GNUNET_ALIGN;
   struct ConnectInfoMessage *connect_msg = (struct ConnectInfoMessage *) buf;
+  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
 
+#if IGNORE_INBOUND_QUOTA
+  bandwidth_min = n->primary_address.bandwidth_out;
+#else
+  bandwidth_min = GNUNET_BANDWIDTH_value_min (n->primary_address.bandwidth_out,
+                                              n->neighbour_receive_quota);
+#endif
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "We are now connected to peer `%s'\n",
-              GNUNET_i2s (peer));
+              GNUNET_i2s (&n->id));
   connect_msg->header.size = htons (sizeof(buf));
   connect_msg->header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_CONNECT);
-  connect_msg->id = *peer;
-  connect_msg->quota_in = bandwidth_in;
-  connect_msg->quota_out = bandwidth_out;
-  GST_clients_broadcast (&connect_msg->header, GNUNET_NO);
+  connect_msg->id = n->id;
+  connect_msg->quota_in = n->primary_address.bandwidth_in;
+  connect_msg->quota_out = bandwidth_min;
+  GST_clients_broadcast (&connect_msg->header,
+                         GNUNET_NO);
 }
 
 
@@ -588,21 +592,21 @@
  * Notify our clients (and manipulation) that a peer disconnected from
  * us.
  *
- * @param peer the peer that disconnected
+ * @param n the peer that disconnected
  */
 static void
-neighbours_disconnect_notification (const struct GNUNET_PeerIdentity *peer)
+neighbours_disconnect_notification (struct NeighbourMapEntry *n)
 {
   struct DisconnectInfoMessage disconnect_msg;
 
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Peer `%s' disconnected\n",
-              GNUNET_i2s (peer));
-  GST_manipulation_peer_disconnect (peer);
+              GNUNET_i2s (&n->id));
+  GST_manipulation_peer_disconnect (&n->id);
   disconnect_msg.header.size = htons (sizeof(struct DisconnectInfoMessage));
   disconnect_msg.header.type = htons 
(GNUNET_MESSAGE_TYPE_TRANSPORT_DISCONNECT);
   disconnect_msg.reserved = htonl (0);
-  disconnect_msg.peer = *peer;
+  disconnect_msg.peer = n->id;
   GST_clients_broadcast (&disconnect_msg.header,
                          GNUNET_NO);
 }
@@ -676,23 +680,31 @@
  * Note that the outbound quota is enforced client-side (i.e.
  * in libgnunettransport).
  *
- * @param target affected peer
- * @param quota new quota
+ * @param n affected peer
  */
 static void
-send_outbound_quota_to_clients (const struct GNUNET_PeerIdentity *target,
-                                struct GNUNET_BANDWIDTH_Value32NBO quota)
+send_outbound_quota_to_clients (struct NeighbourMapEntry *n)
 {
   struct QuotaSetMessage q_msg;
+  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
 
+  if (! GNUNET_TRANSPORT_is_connected (n->state))
+    return;
+#if IGNORE_INBOUND_QUOTA
+  bandwidth_min = n->primary_address.bandwidth_out;
+#else
+  bandwidth_min = GNUNET_BANDWIDTH_value_min (n->primary_address.bandwidth_out,
+                                              n->neighbour_receive_quota);
+#endif
+
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Sending outbound quota of %u Bps for peer `%s' to all 
clients\n",
-              ntohl (quota.value__),
-              GNUNET_i2s (target));
+              ntohl (bandwidth_min.value__),
+              GNUNET_i2s (&n->id));
   q_msg.header.size = htons (sizeof (struct QuotaSetMessage));
   q_msg.header.type = htons (GNUNET_MESSAGE_TYPE_TRANSPORT_SET_QUOTA);
-  q_msg.quota = quota;
-  q_msg.peer = (*target);
+  q_msg.quota = bandwidth_min;
+  q_msg.peer = n->id;
   GST_clients_broadcast (&q_msg.header, GNUNET_NO);
 }
 
@@ -753,9 +765,7 @@
   if (GNUNET_TRANSPORT_is_connected (s) &&
       ! GNUNET_TRANSPORT_is_connected (n->state) )
   {
-    neighbours_connect_notification (&n->id,
-                                     n->primary_address.bandwidth_in,
-                                     n->primary_address.bandwidth_out);
+    neighbours_connect_notification (n);
     GNUNET_STATISTICS_set (GST_stats,
                           gettext_noop ("# peers connected"),
                           ++neighbours_connected,
@@ -768,7 +778,7 @@
                           gettext_noop ("# peers connected"),
                           --neighbours_connected,
                           GNUNET_NO);
-    neighbours_disconnect_notification (&n->id);
+    neighbours_disconnect_notification (n);
   }
   n->state = s;
   if ( (timeout.abs_value_us < n->timeout.abs_value_us) &&
@@ -1229,8 +1239,6 @@
                      struct GNUNET_BANDWIDTH_Value32NBO bandwidth_in,
                      struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
-  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
-
   if (session == n->primary_address.session)
   {
     GST_validation_set_address_use (n->primary_address.address,
@@ -1244,14 +1252,7 @@
     if (n->primary_address.bandwidth_out.value__ != bandwidth_out.value__)
     {
       n->primary_address.bandwidth_out = bandwidth_out;
-#if IGNORE_INBOUND_QUOTA
-      bandwidth_min = bandwidth_out;
-#else
-      bandwidth_min = GNUNET_BANDWIDTH_value_min (bandwidth_out,
-                                                  n->neighbour_receive_quota);
-#endif
-      send_outbound_quota_to_clients (&address->peer,
-                                      bandwidth_min);
+      send_outbound_quota_to_clients (n);
     }
     return;
   }
@@ -1288,14 +1289,7 @@
                                   GNUNET_YES);
   set_incoming_quota (n,
                       bandwidth_in);
-#if IGNORE_INBOUND_QUOTA
-  bandwidth_min = bandwidth_out;
-#else
-  bandwidth_min = GNUNET_BANDWIDTH_value_min (bandwidth_out,
-                                              n->neighbour_receive_quota);
-#endif
-  send_outbound_quota_to_clients (&address->peer,
-                                  bandwidth_min);
+  send_outbound_quota_to_clients (n);
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Neighbour `%s' switched to address `%s'\n",
               GNUNET_i2s (&n->id),
@@ -2215,7 +2209,8 @@
                          GNUNET_TIME_UNIT_FOREVER_ABS);
   GNUNET_assert (GNUNET_OK ==
                  GNUNET_CONTAINER_multipeermap_put (neighbours,
-                                                    &n->id, n,
+                                                    &n->id,
+                                                    n,
                                                     
GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY));
   n->suggest_handle = GNUNET_ATS_connectivity_suggest (GST_ats_connect,
                                                        peer);
@@ -2544,7 +2539,6 @@
                          struct GNUNET_BANDWIDTH_Value32NBO bandwidth_out)
 {
   struct NeighbourMapEntry *n;
-  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
 
   n = lookup_neighbour (&address->peer);
   if ( (NULL == n) ||
@@ -2572,14 +2566,7 @@
   if (n->primary_address.bandwidth_out.value__ != bandwidth_out.value__)
   {
     n->primary_address.bandwidth_out = bandwidth_out;
-#if IGNORE_INBOUND_QUOTA
-    bandwidth_min = bandwidth_out;
-#else
-    bandwidth_min = GNUNET_BANDWIDTH_value_min (bandwidth_out,
-                                                n->neighbour_receive_quota);
-#endif
-    send_outbound_quota_to_clients (&address->peer,
-                                    bandwidth_min);
+    send_outbound_quota_to_clients (n);
   }
   return GNUNET_OK;
 }
@@ -3687,7 +3674,6 @@
 {
   struct NeighbourMapEntry *n;
   const struct SessionQuotaMessage *sqm;
-  struct GNUNET_BANDWIDTH_Value32NBO bandwidth_min;
 
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Received QUOTA message from peer `%s'\n",
@@ -3714,14 +3700,7 @@
   n->neighbour_receive_quota
     = GNUNET_BANDWIDTH_value_max (GNUNET_CONSTANTS_DEFAULT_BW_IN_OUT,
                                   GNUNET_BANDWIDTH_value_init (ntohl 
(sqm->quota)));
-#if IGNORE_INBOUND_QUOTA
-  bandwidth_min = n->primary_address.bandwidth_out;
-#else
-  bandwidth_min = GNUNET_BANDWIDTH_value_min (n->primary_address.bandwidth_out,
-                                              n->neighbour_receive_quota);
-#endif
-  send_outbound_quota_to_clients (peer,
-                                  bandwidth_min);
+  send_outbound_quota_to_clients (n);
 }
 
 

Modified: gnunet/src/transport/transport_api.c
===================================================================
--- gnunet/src/transport/transport_api.c        2015-10-17 19:02:04 UTC (rev 
36518)
+++ gnunet/src/transport/transport_api.c        2015-10-17 19:34:43 UTC (rev 
36519)
@@ -743,6 +743,8 @@
     if (size < sizeof (struct ConnectInfoMessage))
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     cim = (const struct ConnectInfoMessage *) msg;
@@ -750,6 +752,8 @@
         sizeof (struct ConnectInfoMessage))
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     LOG (GNUNET_ERROR_TYPE_DEBUG,
@@ -759,6 +763,8 @@
     if (NULL != n)
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     n = neighbour_add (h,
@@ -777,6 +783,8 @@
     if (size != sizeof (struct DisconnectInfoMessage))
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     dim = (const struct DisconnectInfoMessage *) msg;
@@ -788,6 +796,8 @@
     if (NULL == n)
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     neighbour_delete (h,
@@ -798,6 +808,8 @@
     if (size != sizeof (struct SendOkMessage))
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     okm = (const struct SendOkMessage *) msg;
@@ -811,9 +823,11 @@
                         &okm->peer);
     if (NULL == n)
     {
-      /* we should never get a 'SEND_OK' for a peer that we are not
+      /* We should never get a 'SEND_OK' for a peer that we are not
          connected to */
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     if (bytes_physical >= bytes_msg)
@@ -847,6 +861,8 @@
         sizeof (struct InboundMessage) + sizeof (struct GNUNET_MessageHeader))
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     im = (const struct InboundMessage *) msg;
@@ -854,6 +870,8 @@
     if (ntohs (imm->size) + sizeof (struct InboundMessage) != size)
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     LOG (GNUNET_ERROR_TYPE_DEBUG,
@@ -863,6 +881,8 @@
     if (NULL == n)
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     if (NULL != h->rec)
@@ -874,12 +894,19 @@
     if (size != sizeof (struct QuotaSetMessage))
     {
       GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
     }
     qm = (const struct QuotaSetMessage *) msg;
     n = neighbour_find (h, &qm->peer);
     if (NULL == n)
+    {
+      GNUNET_break (0);
+      h->reconnecting = GNUNET_YES;
+      disconnect_and_schedule_reconnect (h);
       break;
+    }
     LOG (GNUNET_ERROR_TYPE_DEBUG,
          "Receiving SET_QUOTA message for `%s' with quota %u\n",
          GNUNET_i2s (&qm->peer),
@@ -1305,7 +1332,7 @@
 {
   struct GNUNET_TRANSPORT_TransmitHandle *th;
 
-  GNUNET_assert (h->reconnect_task == NULL);
+  GNUNET_assert (NULL == h->reconnect_task);
   if (NULL != h->cth)
   {
     GNUNET_CLIENT_notify_transmit_ready_cancel (h->cth);