gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] r37617 - gnunet/src/cadet


From: gnunet
Subject: [GNUnet-SVN] r37617 - gnunet/src/cadet
Date: Fri, 29 Jul 2016 23:17:38 +0200

Author: lynx
Date: 2016-07-29 23:17:38 +0200 (Fri, 29 Jul 2016)
New Revision: 37617

Modified:
   gnunet/src/cadet/gnunet-service-cadet_peer.c
Log:
cadet: rollback + warning message for posterity

Modified: gnunet/src/cadet/gnunet-service-cadet_peer.c
===================================================================
--- gnunet/src/cadet/gnunet-service-cadet_peer.c        2016-07-29 20:32:23 UTC 
(rev 37616)
+++ gnunet/src/cadet/gnunet-service-cadet_peer.c        2016-07-29 21:17:38 UTC 
(rev 37617)
@@ -787,13 +787,12 @@
     GNUNET_ATS_connectivity_suggest_cancel (peer->connectivity_suggestion);
     peer->connectivity_suggestion = NULL;
   }
-    /* Following check was 'while' instead of 'if', but GCP_queue_destroy
-     * frees 'peer->queue_head' so the while checks on freed memory.
-     * Not sure if 'if' is what you wanted, but 'while' can't be
-     * correct. --lynX
+  while (NULL != peer->queue_head)
+  {
+    /* This function destroys the current peer->queue_head but
+     * replaces it with the next in the queue, so it is correct
+     * to while() here.
      */
-  if (NULL != peer->queue_head)
-  {
     GCP_queue_destroy (peer->queue_head, GNUNET_YES, GNUNET_NO, 0);
   }
   if (NULL != peer->core_transmit)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]