gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [gnurl] 48/63: singlesocket: use separate variable for inne


From: gnunet
Subject: [GNUnet-SVN] [gnurl] 48/63: singlesocket: use separate variable for inner loop
Date: Fri, 07 Jun 2019 18:37:10 +0200

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit c36f42839d88b0e4c938e80ebd5da4c765b0264e
Author: Daniel Stenberg <address@hidden>
AuthorDate: Fri May 31 23:00:06 2019 +0200

    singlesocket: use separate variable for inner loop
    
    An inner loop within the singlesocket() function wrongly re-used the
    variable for the outer loop which then could cause an infinite
    loop. Change to using a separate variable!
    
    Reported-by: Eric Wu
    Fixes #3970
    Closes #3973
---
 lib/multi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/multi.c b/lib/multi.c
index ec0318735..02f846033 100644
--- a/lib/multi.c
+++ b/lib/multi.c
@@ -2252,14 +2252,14 @@ static CURLMcode singlesocket(struct Curl_multi *multi,
     actions[i] = action;
     if(entry) {
       /* check if new for this transfer */
-      for(i = 0; i< data->numsocks; i++) {
-        if(s == data->sockets[i]) {
-          prevaction = data->actions[i];
+      int j;
+      for(j = 0; j< data->numsocks; j++) {
+        if(s == data->sockets[j]) {
+          prevaction = data->actions[j];
           sincebefore = TRUE;
           break;
         }
       }
-
     }
     else {
       /* this is a socket we didn't have before, add it to the hash! */

-- 
To stop receiving notification emails like this one, please contact
address@hidden.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]