[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] [libmicrohttpd] 26/154: indentation, comments, issue
From: |
gnunet |
Subject: |
[GNUnet-SVN] [libmicrohttpd] 26/154: indentation, comments, issue |
Date: |
Mon, 19 Aug 2019 10:15:38 +0200 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository libmicrohttpd.
commit a2fefb3b732237cadca7c8562b3160ce8f23b09e
Author: Christian Grothoff <address@hidden>
AuthorDate: Fri Jul 19 19:27:48 2019 +0200
indentation, comments, issue
---
src/microhttpd/mhd_send.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/microhttpd/mhd_send.c b/src/microhttpd/mhd_send.c
index d713f1a8..6215af65 100644
--- a/src/microhttpd/mhd_send.c
+++ b/src/microhttpd/mhd_send.c
@@ -75,12 +75,10 @@ MHD_send_on_connection_ (struct MHD_Connection *connection,
size_t buffer_size,
enum MHD_SendSocketOptions options)
{
- //size_t length, opt1, opt2;
- // ssize_t num_bytes;
- //int errno = 0;
bool want_cork;
bool have_cork;
bool have_more;
+ bool use_corknopush;
bool using_tls = false;
/* The socket. */
MHD_socket s = connection->socket_fd;
@@ -128,8 +126,6 @@ MHD_send_on_connection_ (struct MHD_Connection *connection,
have_more = false;
#endif
- bool use_corknopush;
-
#if TCP_NODELAY
use_corknopush = false;
#elif TCP_CORK
@@ -180,8 +176,7 @@ MHD_send_on_connection_ (struct MHD_Connection *connection,
TCP_NOPUSH,
(const void *) &on_val,
sizeof (on_val));
- // TODO: set corknopush to true here?
- // connection->sk_tcp_cork_nopush_on = true;
+ connection->sk_tcp_nodelay_on = false;
}
}
#endif
@@ -275,13 +270,17 @@ MHD_send_on_connection_ (struct MHD_Connection
*connection,
if (0 == setsockopt (connection->socket_fd,
IPPROTO_TCP,
TCP_CORK,
- (const void *) &off_val,
+ (const void *) &off_val, // WHY OFF?
sizeof (off_val)))
+ {
+ connection->sk_tcp_nodelay_on = true; // ???
+ }
else if (0 == setsockopt (connection->socket_fd,
IPPROTO_TCP,
TCP_NODELAY,
(const void *) &off_val,
- sizeof (off_val))) {
+ sizeof (off_val)))
+ {
connection->sk_tcp_nodelay_on = false;
}
}
@@ -304,7 +303,8 @@ MHD_send_on_connection_ (struct MHD_Connection *connection,
IPPROTO_TCP,
TCP_NODELAY,
(const void *) &on_val,
- sizeof (on_val))) {
+ sizeof (on_val)))
+ {
connection->sk_tcp_nodelay_on = true;
}
}
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [GNUnet-SVN] [libmicrohttpd] 37/154: flatten if statements, add initial TCP_NOPUSH to MHD_send_on_connection2_, (continued)
- [GNUnet-SVN] [libmicrohttpd] 37/154: flatten if statements, add initial TCP_NOPUSH to MHD_send_on_connection2_, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 39/154: indent, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 33/154: replace connection->send_cls(), gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 13/154: mhd_send.c: fix compiler error about MSG_MORE when MSG_MORE is undefined., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 18/154: more from connection.c, without checks so far., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 16/154: mhd_send: Use MHD_SCKT_OPT_BOOL_ for setsockopt optval., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 28/154: fixes, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 43/154: move comment above function., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 25/154: inline TLS logic, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 15/154: iAdd headerfile for mhd_send., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 26/154: indentation, comments, issue,
gnunet <=
- [GNUnet-SVN] [libmicrohttpd] 29/154: fix err logic, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 10/154: mhd_send: Restructure., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 27/154: fixes, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 32/154: setsockopt(): check return value., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 21/154: mhd_send.c: Use daemon from connection struct., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 45/154: fix compiler error., gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 44/154: remove verbose comments in mhd_send.c, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 55/154: doxygen: MHD_SSO, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 30/154: comments, gnunet, 2019/08/19
- [GNUnet-SVN] [libmicrohttpd] 49/154: more OLDSOCK., gnunet, 2019/08/19