[gnurl] 112/151: conncache: CONNECT_ONLY connections assumed always in-use

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 1d5c427d7fd6c206de4b010f618659a7a9b38cff
Author: Daniel Stenberg <address@hidden>
AuthorDate: Tue Dec 10 10:39:16 2019 +0100

    conncache: CONNECT_ONLY connections assumed always in-use
    
    This makes them never to be considered "the oldest" to be discarded when
    reaching the connection cache limit. The reasoning here is that
    CONNECT_ONLY is primarily used in combination with using the
    connection's socket post connect and since that is used outside of
    curl's knowledge we must assume that it is in use until explicitly
    closed.
    
    Reported-by: Pavel Pavlov
    Reported-by: Pavel Löbl
    Fixes #4426
    Fixes #4369
    Closes #4696
---
 lib/conncache.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/conncache.c b/lib/conncache.c
index a23244cf6..28044644b 100644
--- a/lib/conncache.c
+++ b/lib/conncache.c
@@ -519,7 +519,8 @@ Curl_conncache_extract_oldest(struct Curl_easy *data)
     while(curr) {
       conn = curr->ptr;
 
-      if(!CONN_INUSE(conn) && !conn->data && !conn->bits.close) {
+      if(!CONN_INUSE(conn) && !conn->data && !conn->bits.close &&
+         !conn->bits.connect_only) {
         /* Set higher score for the age passed since the connection was used */
         score = Curl_timediff(now, conn->lastused);
 

-- 
To stop receiving notification emails like this one, please contact
address@hidden.