[libeufin] branch master updated: Todo comments.

[gnunet]

This is an automated email from the git hooks/post-receive script.

marcello pushed a commit to branch master
in repository libeufin.

The following commit(s) were added to refs/heads/master by this push:
     new 2d13530  Todo comments.
2d13530 is described below

commit 2d135300998095e57a71cd378ff202f6a10e0353
Author: Marcello Stanisci <address@hidden>
AuthorDate: Mon Mar 23 20:34:11 2020 +0100

    Todo comments.
---
 .../tech/libeufin/sandbox/EbicsProtocolBackend.kt  | 40 ++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

diff --git 
a/sandbox/src/main/kotlin/tech/libeufin/sandbox/EbicsProtocolBackend.kt 
b/sandbox/src/main/kotlin/tech/libeufin/sandbox/EbicsProtocolBackend.kt
index dd60f37..98a3fdd 100644
--- a/sandbox/src/main/kotlin/tech/libeufin/sandbox/EbicsProtocolBackend.kt
+++ b/sandbox/src/main/kotlin/tech/libeufin/sandbox/EbicsProtocolBackend.kt
@@ -139,6 +139,38 @@ private suspend fun 
ApplicationCall.respondEbicsKeyManagement(
 
 fun buildCamtString(history: SizedIterable<BankTransactionEntity>, type: Int): 
String {
 
+    /**
+     * Booking period: we keep two "lines" of booking periods; one for c52 and 
one for c53.
+     * Each line's period ends when the user requests the c52/c53, and a new 
period is started.
+     */
+
+    /**
+     * Checklist of data to be retrieved from the database.
+     *
+     * - IBAN(s): debitor and creditor's
+     * - last IDs (of all kinds) ?
+     */
+
+    /**
+     * What needs to be calculated before filling the document:
+     *
+     * - The balance _after_ all the transactions from the fresh
+     *   booking period.
+     */
+
+    /**
+     * ID types required:
+     *
+     * - Message Id
+     * - Statement / Report Id
+     * - Electronic sequence number
+     * - Legal sequence number
+     * - Entry Id by the Servicer
+     * - Payment information Id
+     * - Proprietary code of the bank transaction
+     * - Id of the servicer (Issuer and Code)
+     */
+
     return constructXml(indent = true) {
         root("Document") {
             attribute("xmlns", 
"urn:iso:std:iso:20022:tech:xsd:camt.053.001.08")
@@ -149,8 +181,12 @@ fun buildCamtString(history: 
SizedIterable<BankTransactionEntity>, type: Int): S
                     element("MsgId")
                     element("CreDtTm")
                     element("MsgPgntn") {
-                        element("PgNb")
-                        element("LastPgInd")
+                        element("PgNb") {
+                            text("001")
+                        }
+                        element("LastPgInd") {
+                            text("true")
+                        }
                     }
                 }
                 element(if (type == 52) "Rpt" else "Stmt") {

-- 
To stop receiving notification emails like this one, please contact
address@hidden.