gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnurl] 191/282: runtests: fix output to command log


From: gnunet
Subject: [gnurl] 191/282: runtests: fix output to command log
Date: Wed, 01 Apr 2020 14:30:56 +0200

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 711f022c055ae0932b864699ca8d49c057f07ee1
Author: Jay Satiro <address@hidden>
AuthorDate: Sat Feb 29 03:11:06 2020 -0500

    runtests: fix output to command log
    
    - Record only the command of the most recently ran test in the command
      log.
    
    This is a follow-up to 02988b7 from several weeks ago which fixed
    writing to the command log, however it saved all commands for all tests
    instead of just the most recently ran test as we would now expect.
    
    Fixes https://github.com/curl/curl/commit/02988b7#commitcomment-37546876
    Closes https://github.com/curl/curl/pull/5001
---
 tests/runtests.pl | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/tests/runtests.pl b/tests/runtests.pl
index 1bd402562..e867f2d95 100755
--- a/tests/runtests.pl
+++ b/tests/runtests.pl
@@ -2566,7 +2566,7 @@ sub cleardir {
     opendir(DIR, $dir) ||
         return 0; # can't open dir
     while($file = readdir(DIR)) {
-        if(($file !~ /^\./) && ($file ne $CURLLOG)) {
+        if(($file !~ /^\./)) {
             unlink("$dir/$file");
             $count++;
         }
@@ -3721,7 +3721,9 @@ sub singletest {
         logmsg "$CMDLINE\n";
     }
 
+    open(CMDLOG, ">", "$LOGDIR/$CURLLOG");
     print CMDLOG "$CMDLINE\n";
+    close(CMDLOG);
 
     unlink("core");
 
@@ -5410,14 +5412,6 @@ if($scrambleorder) {
     $TESTCASES = join(" ", @rand);
 }
 
-#######################################################################
-# Start the command line log
-#
-open(CMDLOG, ">", "$LOGDIR/$CURLLOG") ||
-    logmsg "can't log command lines to $CURLLOG\n";
-
-#######################################################################
-
 # Display the contents of the given file.  Line endings are canonicalized
 # and excessively long files are elided
 sub displaylogcontent {
@@ -5583,11 +5577,6 @@ if(azure_check_environment() && $AZURE_RUN_ID) {
     $AZURE_RUN_ID = azure_update_test_run($AZURE_RUN_ID);
 }
 
-#######################################################################
-# Close command log
-#
-close(CMDLOG);
-
 # Tests done, stop the servers
 stopservers($verbose);
 

-- 
To stop receiving notification emails like this one, please contact
address@hidden.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]