[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-merchant] branch master updated: clarify comment

From: gnunet
Subject: [taler-merchant] branch master updated: clarify comment
Date: Mon, 12 Oct 2020 22:19:58 +0200

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository merchant.

The following commit(s) were added to refs/heads/master by this push:
     new cf733c2  clarify comment
cf733c2 is described below

commit cf733c2b743b1e2d3c1e7a7d296aff71d70cf4e2
Author: Christian Grothoff <>
AuthorDate: Mon Oct 12 22:19:56 2020 +0200

    clarify comment
 src/backend/taler-merchant-httpd_private-get-orders-ID.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/backend/taler-merchant-httpd_private-get-orders-ID.c 
index 1d4bde2..dbac229 100644
--- a/src/backend/taler-merchant-httpd_private-get-orders-ID.c
+++ b/src/backend/taler-merchant-httpd_private-get-orders-ID.c
@@ -820,8 +820,13 @@ TMH_private_get_orders_ID (const struct TMH_RequestHandler 
   if (NULL != gorc->contract_terms)
-    /* Clear old contract terms, might be from an earlier unclaimed contract
-       and thus could have changed during claiming. */
+    /* Free memory filled with old contract terms before fetching the latest
+       ones from the DB.  Note that we cannot simply skip the database
+       interaction as the contract terms loaded previously might be from an
+       earlier *unclaimed* order state (which we loaded in a previous
+       invocation of this function and we are back here due to long polling)
+       and thus the contract terms could have changed during claiming. Thus,
+       we need to fetch the latest contract terms from the DB again. *///
     json_decref (gorc->contract_terms);
     gorc->contract_terms = NULL;
     gorc->fulfillment_url = NULL;

To stop receiving notification emails like this one, please contact

reply via email to

[Prev in Thread] Current Thread [Next in Thread]