gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[libmicrohttpd] branch master updated: Added TODO comments and corrected


From: gnunet
Subject: [libmicrohttpd] branch master updated: Added TODO comments and corrected log message
Date: Sat, 05 Jun 2021 21:19:13 +0200

This is an automated email from the git hooks/post-receive script.

karlson2k pushed a commit to branch master
in repository libmicrohttpd.

The following commit(s) were added to refs/heads/master by this push:
     new 149eaabc Added TODO comments and corrected log message
149eaabc is described below

commit 149eaabc678adc8845421b91e477b0b39e792ecd
Author: Evgeny Grin (Karlson2k) <k2k@narod.ru>
AuthorDate: Sat Jun 5 22:16:15 2021 +0300

    Added TODO comments and corrected log message
---
 src/microhttpd/connection.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/microhttpd/connection.c b/src/microhttpd/connection.c
index 3102b24f..044b9a01 100644
--- a/src/microhttpd/connection.c
+++ b/src/microhttpd/connection.c
@@ -2381,6 +2381,8 @@ process_request_body (struct MHD_Connection *connection)
 
   if (NULL != connection->response)
   {
+    /* TODO: discard all read buffer as early response
+     * means that connection have to be closed. */
     /* already queued a response, discard remaining upload
        (but not more, there might be another request after it) */
     size_t purge;
@@ -2599,6 +2601,7 @@ process_request_body (struct MHD_Connection *connection)
       connection->remaining_upload_size -= processed_size;
   }
   while (MHD_NO != instant_retry);
+  /* TODO: zero out reused memory region */
   if ( (available > 0) &&
        (buffer_head != connection->read_buffer) )
     memmove (connection->read_buffer,
@@ -3840,7 +3843,7 @@ MHD_connection_handle_idle (struct MHD_Connection 
*connection)
         /* oops - close! */
         CONNECTION_CLOSE_ERROR (connection,
                                 _ (
-                                  "Closing connection (failed to create 
response header)."));
+                                  "Closing connection (failed to create 
response footer)."));
         continue;
       }
       if ( (! connection->have_chunked_upload) ||

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]