gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[taler-donau] branch master updated: TODO -> FIXME


From: gnunet
Subject: [taler-donau] branch master updated: TODO -> FIXME
Date: Wed, 01 Jan 2025 14:14:51 +0100

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository donau.

The following commit(s) were added to refs/heads/master by this push:
     new 89b3c25  TODO -> FIXME
89b3c25 is described below

commit 89b3c2536eb9cbdaebb72c08905182a5bf6e76fb
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Wed Jan 1 14:14:42 2025 +0100

    TODO -> FIXME
---
 debian/control                               |  2 +-
 src/donau/donau-httpd_batch-issue.c          |  2 +-
 src/include/donau_service.h                  |  4 +-
 src/lib/donau_api_charities_get.c            | 76 ++++++++++++++--------------
 src/lib/donau_api_csr_post.c                 |  2 +-
 src/testing/testing_api_cmd_issue_receipts.c |  2 +-
 src/testing/testing_api_loop.c               |  2 +-
 7 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/debian/control b/debian/control
index d87b048..445bdd1 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends:
  bash,
  debhelper-compat (= 12),
  gettext,
- libgnunet-dev (>=0.20),
+ libgnunet-dev (>=0.22.3),
  libcurl4-gnutls-dev (>=7.35.0) | libcurl4-openssl-dev (>= 7.35.0),
  libgcrypt20-dev (>=1.8),
  libgnutls28-dev (>=3.2.12),
diff --git a/src/donau/donau-httpd_batch-issue.c 
b/src/donau/donau-httpd_batch-issue.c
index 262cefe..674ef32 100644
--- a/src/donau/donau-httpd_batch-issue.c
+++ b/src/donau/donau-httpd_batch-issue.c
@@ -62,7 +62,7 @@ parse_json_bkp (struct 
DONAU_BlindedUniqueDonorIdentifierKeyPair *bkp,
     GNUNET_break_op (0);
     return GNUNET_SYSERR;
   }
-  /* TODO: Check for duplicate blinded UDIs.*/
+  /* FIXME: Check for duplicate blinded UDIs.*/
   return GNUNET_OK;
 }
 
diff --git a/src/include/donau_service.h b/src/include/donau_service.h
index 7eb48d1..2297d21 100644
--- a/src/include/donau_service.h
+++ b/src/include/donau_service.h
@@ -483,7 +483,7 @@ struct DONAU_BatchIssueResponse
 
     struct
     {
-      /* TODO: returning full details is not implemented */
+      /* FIXME: returning full details is not implemented */
     } conflict;
 
   } details;
@@ -789,7 +789,7 @@ struct DONAU_CsRBatchIssueResponse
      */
     struct
     {
-      /* TODO: returning full details is not implemented */
+      /* FIXME: returning full details is not implemented */
     } gone;
 
   } details;
diff --git a/src/lib/donau_api_charities_get.c 
b/src/lib/donau_api_charities_get.c
index b75efb3..1116d2d 100644
--- a/src/lib/donau_api_charities_get.c
+++ b/src/lib/donau_api_charities_get.c
@@ -68,8 +68,8 @@ struct DONAU_CharitiesGetHandle
  */
 static enum GNUNET_GenericReturnValue
 handle_charities_get_ok (const json_t *resp_obj,
-                       struct DONAU_CharitiesGetHandle *cgh,
-                                          struct DONAU_GetCharitiesResponse 
*gcresp)
+                         struct DONAU_CharitiesGetHandle *cgh,
+                         struct DONAU_GetCharitiesResponse *gcresp)
 {
   struct DONAU_CharitySummary *charities = gcresp->details.ok.charity;
   const char *name;
@@ -82,34 +82,34 @@ handle_charities_get_ok (const json_t *resp_obj,
     = json_array_size (resp_obj);
   if (0 != num_charity)
   {
-         unsigned int index;
-         json_t *charity_obj;
-         json_array_foreach (resp_obj,
-                                                 index,
-                                                 charity_obj)
-         {
-                 struct GNUNET_JSON_Specification spec[] = {
-                       GNUNET_JSON_spec_string ("name", &name),
-                       TALER_JSON_spec_amount_any ("max_per_year",
-                                                                               
&charities[index].max_per_year),
-                       TALER_JSON_spec_amount_any ("receipts_to_date",
-                                                                               
&charities[index].
-                                                                               
receipts_to_date),
-                       GNUNET_JSON_spec_uint64 ("charity_id",
-                                                                        
&charities[index].charity_id),
-                       GNUNET_JSON_spec_end ()
-                 };
-                 if (GNUNET_OK !=
-                         GNUNET_JSON_parse (resp_obj,
-                                                                spec,
-                                                                NULL,
-                                                                NULL))
-                 {
-                       GNUNET_break_op (0);
-                       return GNUNET_SYSERR;
-                 }
-                 charities[index].name = GNUNET_strdup (name);
-         }
+    unsigned int index;
+    json_t *charity_obj;
+    json_array_foreach (resp_obj,
+                        index,
+                        charity_obj)
+    {
+      struct GNUNET_JSON_Specification spec[] = {
+        GNUNET_JSON_spec_string ("name", &name),
+        TALER_JSON_spec_amount_any ("max_per_year",
+                                    &charities[index].max_per_year),
+        TALER_JSON_spec_amount_any ("receipts_to_date",
+                                    &charities[index].
+                                    receipts_to_date),
+        GNUNET_JSON_spec_uint64 ("charity_id",
+                                 &charities[index].charity_id),
+        GNUNET_JSON_spec_end ()
+      };
+      if (GNUNET_OK !=
+          GNUNET_JSON_parse (resp_obj,
+                             spec,
+                             NULL,
+                             NULL))
+      {
+        GNUNET_break_op (0);
+        return GNUNET_SYSERR;
+      }
+      charities[index].name = GNUNET_strdup (name);
+    }
   }
   cgh->cb (cgh->cb_cls,
            gcresp);
@@ -128,8 +128,8 @@ handle_charities_get_ok (const json_t *resp_obj,
  */
 static void
 handle_charities_get_finished (void *cls,
-                             long response_code,
-                             const void *resp_obj)
+                               long response_code,
+                               const void *resp_obj)
 {
   struct DONAU_CharitiesGetHandle *cgh = cls;
   const json_t *j = resp_obj;
@@ -147,8 +147,8 @@ handle_charities_get_finished (void *cls,
   case MHD_HTTP_OK:
     if (GNUNET_OK !=
         handle_charities_get_ok (j,
-                               cgh,
-                                                          &gcresp))
+                                 cgh,
+                                 &gcresp))
     {
       gcresp.hr.http_status = 0;
       gcresp.hr.ec = TALER_EC_GENERIC_REPLY_MALFORMED;
@@ -199,7 +199,7 @@ struct DONAU_CharitiesGetHandle *
 DONAU_charities_get (
   struct GNUNET_CURL_Context *ctx,
   const char *url,
-  const struct DONAU_BearerToken *bearer, // TODO: check authorization
+  const struct DONAU_BearerToken *bearer, // FIXME-#9435: check authorization
   DONAU_GetCharitiesResponseCallback cb,
   void *cb_cls)
 {
@@ -233,9 +233,9 @@ DONAU_charities_get (
     return NULL;
   }
   cgh->job = GNUNET_CURL_job_add_with_ct_json (ctx,
-                                  eh,
-                                  &handle_charities_get_finished,
-                                  cgh);
+                                               eh,
+                                               &handle_charities_get_finished,
+                                               cgh);
   return cgh;
 }
 
diff --git a/src/lib/donau_api_csr_post.c b/src/lib/donau_api_csr_post.c
index c081228..b28541b 100644
--- a/src/lib/donau_api_csr_post.c
+++ b/src/lib/donau_api_csr_post.c
@@ -93,7 +93,7 @@ handle_csr_issue_post_finished (void *cls,
   {
   case MHD_HTTP_CREATED:
     struct GNUNET_JSON_Specification spec[] = {
-      TALER_JSON_spec_exchange_withdraw_values ( // TODO: method for GNUNET
+      TALER_JSON_spec_exchange_withdraw_values ( // FIXME: method for GNUNET
         "ewv",
         (struct TALER_ExchangeWithdrawValues *) 
&csrresp.details.ok.alg_values),
       GNUNET_JSON_spec_end ()
diff --git a/src/testing/testing_api_cmd_issue_receipts.c 
b/src/testing/testing_api_cmd_issue_receipts.c
index 31b7ee9..d051f3a 100644
--- a/src/testing/testing_api_cmd_issue_receipts.c
+++ b/src/testing/testing_api_cmd_issue_receipts.c
@@ -423,7 +423,7 @@ status_run (void *cls,
       break;
     case GNUNET_CRYPTO_BSA_CS:
       struct CSR_Data *csr_data = GNUNET_new (struct CSR_Data);
-      TALER_cs_withdraw_nonce_derive ( // TODO: write new method
+      TALER_cs_withdraw_nonce_derive ( // FIXME: write new method
         (struct TALER_PlanchetMasterSecretP *) &ps,
         &csr_data->nonce.cs_nonce);
       csr_data->ss = ss;
diff --git a/src/testing/testing_api_loop.c b/src/testing/testing_api_loop.c
index 3565bd1..8978053 100644
--- a/src/testing/testing_api_loop.c
+++ b/src/testing/testing_api_loop.c
@@ -75,6 +75,6 @@ DONAU_TESTING_main (char *const *argv,
   // }
   ret = TALER_TESTING_loop (main_cb,
                             main_cb_cls);
-  /* TODO: should we free 'cred' resources here? */
+  /* FIXME: should we free 'cred' resources here? */
   return (GNUNET_OK == ret) ? 0 : 1;
 }

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]