gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] NSBox - user colors


From: Fred Kiefer
Subject: Re: [PATCH] NSBox - user colors
Date: Thu, 15 Jan 2004 21:09:57 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030821

Jeff Teunissen wrote:
Jeff Teunissen wrote:

Attached is a patch that makes the NSBox class not use the NSDrawGroove,
NSDrawBezel, etc. functions (which unconditionally draw a grey
background, overriding the painting of the background by the class).

This allows NSBox to respect the user's color selections, improving the
look of applications that use boxes when the user has set their colors
to non-default values.


Hi Jeff,

I am wondering why your patch replaces NSFrameRect with direct drawing code. I am also unsure, if your code draws correctly on flipped views.

But my main concern is, if this code has the right correspondance between the system colours and the border elements. Could you verify this code against either OpenStep or Cocoa or would the adaptable colours be a GNUstep specific feature?

Otherwise I think, this is a nice idea.

Fred





reply via email to

[Prev in Thread] Current Thread [Next in Thread]