Re: [Gnustep-cvs] r27578 - in /libs/base/trunk: ./ SSL/ Source/ Source/Additions/ Tools/

[Fred Kiefer]

Hi Richard,

could you please explain the background of these changes? From looking
at them I get the impression that our current system of using RETAIN,
RELEASE etc macros doesn't help much in the case of GC, now this was the
main reason to stick with those macros (The ASSGIN macro is different,
that one is valuable in itself). Do you have a proposal of what we
should do in the future instead?

My impression from a short glance at your changes is that lines like
RETAIN(anObject); give compiler warnings about unused values when
compiled. Should we introduce a new macro that wont return a result?
What I don't like is spreading around code like
 IF_NO_GC([anObject retain];)
This looks strange with the semicolon inside the brackets.

Perhaps we could even misuses TEST_RETAIN() and redefine it's semantic
to not return a value. At least in gui the return value never gets used.
(OK, two exceptions in NSSound, but we could fix them)

Fred

Richard Frith-Macdonald wrote:
> Author: rfm
> Date: Mon Jan 12 13:48:46 2009
> New Revision: 27578
> 
> URL: http://svn.gna.org/viewcvs/gnustep?rev=27578&view=rev
> Log:
> garbage collection fixups
> 
> Modified:
>     libs/base/trunk/ChangeLog
>     libs/base/trunk/SSL/GSSSLHandle.m
>     libs/base/trunk/Source/Additions/GCDictionary.m
>     libs/base/trunk/Source/Additions/GNUmakefile
>     libs/base/trunk/Source/Additions/GSCategories.m
>     libs/base/trunk/Source/Additions/GSMime.m
>     libs/base/trunk/Source/Additions/GSXML.m
>     libs/base/trunk/Source/GNUmakefile
>     libs/base/trunk/Source/GSFFIInvocation.m
>     libs/base/trunk/Source/GSFTPURLHandle.m
>     libs/base/trunk/Source/GSFileHandle.m
>     libs/base/trunk/Source/GSHTTPAuthentication.m
>     libs/base/trunk/Source/GSHTTPURLHandle.m
>     libs/base/trunk/Source/GSInvocation.h
>     libs/base/trunk/Source/GSSocketStream.m
>     libs/base/trunk/Source/GSString.m
>     libs/base/trunk/Source/NSArray.m
>     libs/base/trunk/Source/NSBundle.m
>     libs/base/trunk/Source/NSClassDescription.m
>     libs/base/trunk/Source/NSConnection.m
>     libs/base/trunk/Source/NSDebug.m
>     libs/base/trunk/Source/NSDecimalNumber.m
>     libs/base/trunk/Source/NSDistantObject.m
>     libs/base/trunk/Source/NSDistributedNotificationCenter.m
>     libs/base/trunk/Source/NSException.m
>     libs/base/trunk/Source/NSFileManager.m
>     libs/base/trunk/Source/NSHost.m
>     libs/base/trunk/Source/NSIndexPath.m
>     libs/base/trunk/Source/NSInvocation.m
>     libs/base/trunk/Source/NSKeyValueObserving.m
>     libs/base/trunk/Source/NSKeyedUnarchiver.m
>     libs/base/trunk/Source/NSMessagePort.m
>     libs/base/trunk/Source/NSMessagePortNameServer.m
>     libs/base/trunk/Source/NSNumberFormatter.m
>     libs/base/trunk/Source/NSObject.m
>     libs/base/trunk/Source/NSPathUtilities.m
>     libs/base/trunk/Source/NSPortCoder.m
>     libs/base/trunk/Source/NSProcessInfo.m
>     libs/base/trunk/Source/NSPropertyList.m
>     libs/base/trunk/Source/NSProtocolChecker.m
>     libs/base/trunk/Source/NSRunLoop.m
>     libs/base/trunk/Source/NSSerializer.m
>     libs/base/trunk/Source/NSSet.m
>     libs/base/trunk/Source/NSSocketPort.m
>     libs/base/trunk/Source/NSSocketPortNameServer.m
>     libs/base/trunk/Source/NSSpellServer.m
>     libs/base/trunk/Source/NSString.m
>     libs/base/trunk/Source/NSTask.m
>     libs/base/trunk/Source/NSThread.m
>     libs/base/trunk/Source/NSTimeZone.m
>     libs/base/trunk/Source/NSURL.m
>     libs/base/trunk/Source/NSURLHandle.m
>     libs/base/trunk/Source/NSURLProtocol.m
>     libs/base/trunk/Source/NSURLResponse.m
>     libs/base/trunk/Source/NSUserDefaults.m
>     libs/base/trunk/Source/NSValueTransformer.m
>     libs/base/trunk/Tools/AGSOutput.m
>     libs/base/trunk/Tools/AGSParser.m
>     libs/base/trunk/Tools/HTMLLinker.m
>     libs/base/trunk/Tools/autogsdoc.m
>     libs/base/trunk/Tools/plget.m
>     libs/base/trunk/Tools/sfparse.m
>     libs/base/trunk/base.make.in
>     libs/base/trunk/configure
>     libs/base/trunk/configure.ac
>