[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again)
From: |
Timo Schulz |
Subject: |
Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again) |
Date: |
Tue, 22 May 2007 11:44:25 +0200 |
User-agent: |
Icedove 1.5.0.10 (X11/20070329) |
Ludovic Courtes wrote:
Hi,
> err = cdk_stream_tmp_from_mem (data->data, data->size, &input);
> if (!err)
> err = cdk_stream_set_armor_flag (input, 0);
> if (!err)
> err = cdk_keydb_new_from_stream (&keyring->db, 0, input);
> if (err)
> {
> cdk_stream_close (input);
> gnutls_assert ();
> }
>
> That won't work if `cdk_stream_tmp_from_mem ()' returns an error.
Why? input is set to NULL in the function and thus cdk_stream_close
does nothing because the param is NULL.
> How about ChangeLog entries BTW?
IMHO the ChangeLog entries are generated from the CVS commit logs.
Timo
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), (continued)
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/14
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Ludovic Courtès, 2007/05/14
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Ludovic Courtès, 2007/05/14
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Ludovic Courtès, 2007/05/21
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/21
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/21
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/21
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Ludovic Courtès, 2007/05/22
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again),
Timo Schulz <=
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Ludovic Courtès, 2007/05/22
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/22
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Simon Josefsson, 2007/05/22
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/21
- Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/14
Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Timo Schulz, 2007/05/13
Re: [gnutls-dev] [PATCH] Fixing OpenPGP keyring import (again), Simon Josefsson, 2007/05/14