[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] session ticket support

From: Simon Josefsson
Subject: Re: [PATCH] session ticket support
Date: Wed, 05 Aug 2009 10:08:02 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.50 (gnu/linux)

Daiki Ueno <address@hidden> writes:

>>>>>> In <address@hidden> 
>>>>>>  Simon Josefsson <address@hidden> wrote:
>> I suggest renaming these APIs like this:
>>  gnutls_session_ticket_key_allocate
>>  gnutls_session_ticket_key_randomize
>>  gnutls_session_ticket_key_import
>>  gnutls_session_ticket_key_export
> Thanks for the suggestion.  I'll reflect them in the next patch.


>> Also, what do you think about a 'gnutls_session_ticket_key_format_t'
>> parameter?  I think some people may want to export the key in
>> text-format rather than raw binary.
> As another option, how about making gnutls_session_ticket_key_t a public
> struct so that people can write custom export function?

Thinking about that, doesn't a gnutls_datum_t suffice?  Then you don't
need the import/export functions at all.  Possibly the
allocate+randomize function could also be merged into one API:

  int gnutls_session_ticket_key_generate (gnutls_datum_t *key);

The function would allocate and randomize key->data and set key->size
accordingly.  The key->data field needs to be released using gnutls_free
as usual.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]