[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor fixes for gnutls 2.9.4

From: Simon Josefsson
Subject: Re: Minor fixes for gnutls 2.9.4
Date: Mon, 31 Aug 2009 13:00:36 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Fabian Keil <address@hidden> writes:

> The attached patches fix a few minor issues in
> gnutls-20090829.tar.bz2, most of them pointed out by clang.

Thank you, I have applied them all except for 0005 which I decided to
solve differently.

> address@hidden ~/git/gnutls/gnutls-2.9.4 $cat -n lib/opencdk/misc.c | grep 
> 12[34]
>    123    for (node = root->next; node; node = node->next)
>    124      return node;
> and wonder if an if block wouldn't be more suitable here.

Or why not just 'return root->next'?  The code looks strange to me, but
I don't want to change it without a selftest that uses that code.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]