Nettle integration issues

[Ludovic Courtès]

Hello!

In master (commit e3c98490a827a17782434587705be0ee8adaadd3), I have this
problem:

--8<---------------cut here---------------start------------->8---
$ nm .libs/libgnutls.so | grep nettle_sha256_update
                 U nettle_sha256_update

$ nm nettle/.libs/libcrypto.a | grep nettle_sha256_update
                 U nettle_sha256_update
--8<---------------cut here---------------end--------------->8---

This is cured for me by this patch:

diff --git a/lib/Makefile.am b/lib/Makefile.am
index edf5209..34616ee 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -145,8 +145,7 @@ endif
 libgnutls_la_LDFLAGS += $(LTLIBPAKCHOIS)
 
 if ENABLE_NETTLE
-libgnutls_la_LDFLAGS += $(NETTLE_LIBS)
-libgnutls_la_LIBADD += nettle/libcrypto.la
+libgnutls_la_LIBADD += nettle/libcrypto.la $(LTLIBNETTLE)
 else
 libgnutls_la_LDFLAGS += $(LTLIBGCRYPT)
 libgnutls_la_LIBADD += gcrypt/libcrypto.la

Indeed, $(NETTLE_LIBS) isn’t helpful here:

--8<---------------cut here---------------start------------->8---
$ grep NETTLE_LIBS ../config.log 
NETTLE_LIBS='-lgmp -lpthread -lhogweed'
--8<---------------cut here---------------end--------------->8---

What do you think?

Thanks,
Ludo’.