Re: gnutls 2.12.6.1

[Andreas Metzler]

On 2011-06-05 Nikos Mavrogiannopoulos <address@hidden> wrote:
[...]
> Ah, I didn't spot that because I test with nettle. It's not serious
> though, you can ignore it.
[...]

Hello,
Ok, I have disable the two succeeding tests in the Debian build.

There is a small typo in testdsa:
------------------------------------
diff --git a/tests/dsa/testdsa b/tests/dsa/testdsa
index de1b41b..a1236be 100755
--- a/tests/dsa/testdsa
+++ b/tests/dsa/testdsa
@@ -146,15 +146,15 @@ echo "Checking DSA-3072 with TLS 1.0"
 $SERV $DEBUG -p $PORT --priority "NORMAL:-VERS-TLS-ALL:+VERS-TLS1.0" 
--x509certfile $srcdir/cert.dsa.3072.pem --x509keyfile $srcdir/dsa.3072.pem 
>/dev/null 2>&1 & PID=$!
 trap "kill $PID" 1 15 2
 
 # give the server a chance to initialize
 sleep 2
 
 $CLI $DEBUG -p $PORT 127.0.0.1 --insecure </dev/null >/dev/null 2>&1 && \
-  fail "Succeeded connection to a server with DSA 2048 key and TLS 1.0. Should 
have failed!"
+  fail "Succeeded connection to a server with DSA 3072 key and TLS 1.0. Should 
have failed!"
 
 kill $PID
 wait
 
 # DSA 3072 + TLS 1.2
 
 echo "Checking DSA-3072 with TLS 1.2"
------------------------------------

Also the combination of trap with "exit 1" (invoked from fail()) does
not work. The gnutls-serv process is not killed but remains running,
breaking later GnuTLS builds. How about switching from 
$CLI $DEBUG && fail

to

if $CLI $DEBUG -p $PORT 127.0.0.1 --insecure </dev/null >/dev/null 2>&1 ; then
  kill $PID
  fail "Succeeded connection ..."
fi

(I can post a patch, if you want me to.)

cu andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'