Re: Problematic MOZ_BLOCK_PROFILE_DOWNGRADE behavior

[Mike Gerwitz]

On Mon, Oct 28, 2019 at 13:00:05 -0400, Mark H Weaver wrote:
> If someone would like to volunteer to investigate this issue further,
> I'd be grateful.  Probably the first lines to look at are lines
> 4125-4159 in toolkit/xre/nsAppRunner.cpp.  Ideally, we would find a way
> to preserve the downgrade check while making it more coarse-grained.  If
> the profile was last run with a major version of IceCat newer than 68,
> and now there's an attempt to run it with IceCat-68, then it's good to
> block it.  However, it should not block a downgrade from IceCat-68.3 to
> IceCat-68.2, and certainly not between two slightly different micro
> revisions of 68.2.
>
> As a fallback, we could simply disable this MOZ_BLOCK_PROFILE_DOWNGRADE
> for now, and re-enable it some time later but well before version 68
> loses upstream support, in the hopes that by the time IceCat-76 is out,
> all users of IceCat-68 will be running at least IceCat-68.5, say.
>
> Thoughts?  Volunteers?

I agree with disabling it for now.  I can help investigate, but it may
be a couple of days before I'm able to do so.

> In any case, thanks for reading this far :)

Thank you for investigating!

-- 
Mike Gerwitz
Free Software Hacker+Activist | GNU Maintainer & Volunteer
GPG: D6E9 B930 028A 6C38 F43B  2388 FEF6 3574 5E6F 6D05
https://mikegerwitz.com

signature.asc
Description: PGP signature