[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: housekeeping changes

From: bill-auger
Subject: Re: housekeeping changes
Date: Mon, 1 Feb 2021 00:16:05 -0500

some suggested tweaks to the tweaks (WRT the
'refactor-into-functions' branch)

* the changes in fetch_source() introduced a bug - if the
  "Removing existing invalid Firefox tarball" branch is taken, no
  source-ball would be present after fetch_source() returns

* give local scope to all function-specific variables, and
  remove the unused variable

Attachment: fetch_source-check-existence-after-verify.patch
Description: Text Data

Attachment: validate_env-local-vars.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]