Re: can't build without a time binary

[Vladimir Mezentsev]

On 9/25/23 08:56, Simon Sobisch wrote:
> please make that optional, for example by a make variable TIME that is 
> set to "time", or even test for the time binary in configure and 
> AC_SUBST this


 We don't need to depend on /usr/bin/time.
I suggest to make  the following fix:

% diff --git a/Makefile.am b/Makefile.am
index fe8b01a..8607e3d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -554,7 +554,7 @@ $(JAVA_ANMODULE_DIR) $(JAVA_ANALYZER_DIR) 
$(JAVA_PROFAPI_DIR) $(JAVA_ANMODULES_D

 LocaleString.class: $(srcdir)/tools/LocaleString.java
        @echo "================= $@"
-       time $(JAVAC) $(JAVAC_FLAGS) -d . $(srcdir)/tools/LocaleString.java
+       $(JAVAC) $(JAVAC_FLAGS) -d . $(srcdir)/tools/LocaleString.java

 $(anmodule_PROPERTIES): $(JAVA_ANMODULE_DIR) $(anmodule_FILES) 
LocaleString.class \
                      $(srcdir)/gprofng.properties
@@ -573,7 +573,7 @@ anmodule_JAR = gprofng.jar
 $(anmodule_JAR): $(JAVA_ANMODULE_DIR) $(anmodule_MF) $(anmodule_FILES) \
                 $(anmodule_PROPERTIES) $(anmodule_RESOURCE:%=$(srcdir)/%)
        @echo "================= $@"
-       time $(JAVAC) -cp $(srcdir) $(JAVAC_FLAGS) -d . 
$(srcdir)/$(JAVA_ANMODULE_DIR)/Analyzer.java
+       $(JAVAC) -cp $(srcdir) $(JAVAC_FLAGS) -d . 
$(srcdir)/$(JAVA_ANMODULE_DIR)/Analyzer.java
        $(JAR) $(JAR_FLAGS) $@ $(anmodule_MF) $(GPROFNG_CLASSES) \
                $(anmodule_RESOURCE:%=-C $(srcdir) %) 
$(anmodule_PROPERTIES)

@@ -600,7 +600,7 @@ ANALYZER_JAR = gprofng-analyzer.jar
 $(ANALYZER_JAR): $(JAVA_ANALYZER_DIR) $(anmodule_JAR) \
                    $(ANALYZER_MF) $(ANALYZER_FILES) $(ANALYZER_PROPERTIES)
        @echo "================= $@"
-       time $(JAVAC) -classpath $(anmodule_JAR) $(JAVAC_FLAGS) -d . 
$(ANALYZER_FILES)
+       $(JAVAC) -classpath $(anmodule_JAR) $(JAVAC_FLAGS) -d . 
$(ANALYZER_FILES)
        echo "Create $(ANALYZER_JAR) in `pwd`"
        $(JAR) $(JAR_FLAGS) $@ $(ANALYZER_MF) $(ANALYZER_CLASSES) \
                               $(ANALYZER_PROPERTIES)
diff --git a/Makefile.in b/Makefile.in
index c8e86ce..1f5cdbc 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -1116,7 +1116,7 @@ $(JAVA_ANMODULE_DIR) $(JAVA_ANALYZER_DIR) 
$(JAVA_PROFAPI_DIR) $(JAVA_ANMODULES_D

 LocaleString.class: $(srcdir)/tools/LocaleString.java
        @echo "================= $@"
-       time $(JAVAC) $(JAVAC_FLAGS) -d . $(srcdir)/tools/LocaleString.java
+       $(JAVAC) $(JAVAC_FLAGS) -d . $(srcdir)/tools/LocaleString.java

 $(anmodule_PROPERTIES): $(JAVA_ANMODULE_DIR) $(anmodule_FILES) 
LocaleString.class \
                      $(srcdir)/gprofng.properties
@@ -1129,7 +1129,7 @@ $(anmodule_PROPERTIES): $(JAVA_ANMODULE_DIR) 
$(anmodule_FILES) LocaleString.clas
 $(anmodule_JAR): $(JAVA_ANMODULE_DIR) $(anmodule_MF) $(anmodule_FILES) \
                 $(anmodule_PROPERTIES) $(anmodule_RESOURCE:%=$(srcdir)/%)
        @echo "================= $@"
-       time $(JAVAC) -cp $(srcdir) $(JAVAC_FLAGS) -d . 
$(srcdir)/$(JAVA_ANMODULE_DIR)/Analyzer.java
+       $(JAVAC) -cp $(srcdir) $(JAVAC_FLAGS) -d . 
$(srcdir)/$(JAVA_ANMODULE_DIR)/Analyzer.java
        $(JAR) $(JAR_FLAGS) $@ $(anmodule_MF) $(GPROFNG_CLASSES) \
                $(anmodule_RESOURCE:%=-C $(srcdir) %) 
$(anmodule_PROPERTIES)

@@ -1142,7 +1142,7 @@ $(ANALYZER_PROPERTIES): $(JAVA_ANALYZER_DIR) 
$(ANALYZER_FILES) LocaleString.clas
 $(ANALYZER_JAR): $(JAVA_ANALYZER_DIR) $(anmodule_JAR) \
                    $(ANALYZER_MF) $(ANALYZER_FILES) $(ANALYZER_PROPERTIES)
        @echo "================= $@"
-       time $(JAVAC) -classpath $(anmodule_JAR) $(JAVAC_FLAGS) -d . 
$(ANALYZER_FILES)
+       $(JAVAC) -classpath $(anmodule_JAR) $(JAVAC_FLAGS) -d . 
$(ANALYZER_FILES)
        echo "Create $(ANALYZER_JAR) in `pwd`"
        $(JAR) $(JAR_FLAGS) $@ $(ANALYZER_MF) $(ANALYZER_CLASSES) \
                               $(ANALYZER_PROPERTIES)



 If there are no rejections, on Wednesday I will apply my fixes.

Thank you,
-Vladimir