gprofng-gui-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fix NullPointerException in writeHostNames


From: vladimir . mezentsev
Subject: [PATCH] fix NullPointerException in writeHostNames
Date: Thu, 23 May 2024 15:17:11 -0700

From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>

ChangeLog
2024-05-23  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>

        * org/gprofng/mpmt/persistence/UserPrefPersistence (writeHostNames):
        Make shure authentications is not null.
---
 .../mpmt/persistence/UserPrefPersistence.java | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/org/gprofng/mpmt/persistence/UserPrefPersistence.java 
b/org/gprofng/mpmt/persistence/UserPrefPersistence.java
index d06f1ba..5d6efea 100644
--- a/org/gprofng/mpmt/persistence/UserPrefPersistence.java
+++ b/org/gprofng/mpmt/persistence/UserPrefPersistence.java
@@ -549,17 +549,16 @@ public class UserPrefPersistence {
           attrValues.add(new AttrValuePair(HOSTNAME_NAME_ATTR, hostName));
           attrValues.add(new AttrValuePair(HOSTNAME_PATH_ATTR, path));
           attrValues.add(new AttrValuePair(HOSTNAME_USERNAME_ATTR, userName));
-          if (!Authentication.toXMLString(UserPref.getDefaultAuthentications())
-              .equals(Authentication.toXMLString(authentications))) {
-            attrValues.add(
-                new AttrValuePair(HOSTNAME_AUTH_ATTR, 
Authentication.toXMLString(authentications)));
+          if (authentications != null) {
+            String auth = Authentication.toXMLString(authentications);
+            if (auth != null && UserPref.getDefaultAuthentications() != null
+                && 
!Authentication.toXMLString(UserPref.getDefaultAuthentications())
+                    .equals(auth)) {
+              attrValues.add(new AttrValuePair(HOSTNAME_AUTH_ATTR, auth));
+            }
           }
-          writeEntry(
-              out,
-              indent + 4,
-              HOSTNAME_ELEM,
-              attrValues.toArray(new AttrValuePair[attrValues.size()]),
-              true);
+          writeEntry(out, indent + 4, HOSTNAME_ELEM,
+              attrValues.toArray(new AttrValuePair[attrValues.size()]), true);
         }
       }
       writeEntry(out, indent, HOSTNAME_LIST_ELEM, true);
-- 
2.31.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]