[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-290-g9c3b520

[Jon Schlueter]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".

The branch, master has been updated
       via  9c3b5204a130be036eced73b7a7cde29f9a8157c (commit)
       via  387431a8f84d009444f66195e3327662714143d6 (commit)
       via  1a82f23ce925d509a190b5f98ffaaaee3659d163 (commit)
      from  8122d8643367a33f6169cc1b10f83405d51bd315 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9c3b5204a130be036eced73b7a7cde29f9a8157c
Author: Fred Wright <address@hidden>
Date:   Thu Apr 21 15:57:51 2016 -0700

    Adds regression data for Navika-100.
    
    This is a "with fix" case for the Navika-100 chip, and includes GSV
    data for the real PRN 1.  A previously fixed bug caused a phantom PRN
    1 instance to appear for each GSV sentence, due to misinterpreting the
    signal ID as a satellite ID.
    
    TESTED:
    Verified that this test illustrates the "phantom satellite 1" bug
    prior to that bug's being fixed.

commit 387431a8f84d009444f66195e3327662714143d6
Author: Fred Wright <address@hidden>
Date:   Wed Apr 20 20:01:03 2016 -0700

    Fixes phantom satellites from xxGSVs with a real signal ID.
    
    The change to permit the new signal ID in the GSV sentences broke the
    loop end test, causing an extra "satellite" to be processed when the
    signal ID is present.  The signal ID itself is misinterpreted as a
    satellite ID, with the other three values coming from indexing off the
    end of the buffer (typically getting zeroes).  For receivers
    (incorrectly) reporting a signal ID of zero, this would typically get
    filtered out by the zero-ID filter (but not in non-GPS cases prior to
    fixing another bug), so it often didn't matter.  But for receivers
    reporting a value of 1 (L1 C/A), this resulted in multiple phantom
    satellites with "PRN" 1.  If the real PRN 1 was in use, it also
    screwed up the "active" count.
    
    The fix is just to round the field count down to a multiple of 4 prior
    to using it as the loop's end test.
    
    Also removes an incorrect comment about there being no more than three
    GSV sentences in a group.
    
    TESTED:
    Ran "scons build-all check".  Also verified that, with the Navika
    receiver that reports the signal ID as 1, gpsmon and xgps no longer
    report phantom PRN 1 satellites, and cgps no longer misbehaves in some
    other (uninvestigated) way due to the confusion.

commit 1a82f23ce925d509a190b5f98ffaaaee3659d163
Author: Fred Wright <address@hidden>
Date:   Wed Apr 20 19:30:54 2016 -0700

    Fixes bug in filtering of ID 0 in satellite views.
    
    Because the GSV processing invokes nmeaid_to_prn() before checking for
    an apparent ID of zero, it was possible for zero (or blank) IDs for
    non-GPS sentences to get offset to nonzero values and hence not
    filtered out.  This fix ensures that only nonzero values are adjusted.
    
    Due to this bug, two of the regression tests had incorrect reference
    results:
    
    1) The nl2008u receiver includes the new signal ID field, though the
    reported value is (incorrectly) zero.  Due to another bug (to be fixed
    separately), this is interpreted as an additional ID in each GSV
    sentence.  The zero-ID filter excluded this correctly for GPGSV, but
    for GLGSV it saw phantom entries for "ID 37".
    
    2) The sl869 receiver reports empty fields for unused satellite slots
    in any GSV sentence.  Again, this didn't hurt for GPGSV, and the GLGSV
    test data happens to have a multiple of four satellites, but the QZGSV
    sentences produced phantom "ID 193" entries.
    
    TESTED:
    Ran "scons build-all check", which passed after updating the two
    regression cases noted above.

-----------------------------------------------------------------------

Summary of changes:
 driver_nmea0183.c                  |    5 +-
 test/daemon/navika-100-fix.log     |  186 ++++++++++++++++++++++++++++++
 test/daemon/navika-100-fix.log.chk |  223 ++++++++++++++++++++++++++++++++++++
 test/daemon/nl2008u.log.chk        |   18 +--
 test/daemon/sl869.log.chk          |   30 ++---
 5 files changed, 435 insertions(+), 27 deletions(-)
 create mode 100644 test/daemon/navika-100-fix.log
 create mode 100644 test/daemon/navika-100-fix.log.chk


hooks/post-receive
-- 
GPSD