gpsd-commit-watch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-commit-watch] [SCM] GPSD branch, master, updated. dev-3.19a-382-gc


From: Fred Wright
Subject: [gpsd-commit-watch] [SCM] GPSD branch, master, updated. dev-3.19a-382-gc56ae22
Date: Wed, 20 Mar 2019 19:51:45 -0400 (EDT)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".

The branch, master has been updated
       via  c56ae22be9d6dedc095c484d1c8d6469565dd727 (commit)
       via  46bf8df5048ee28ed7161868918a468a93935c9e (commit)
       via  9a742334e9867d23dc3660f7ad9e2dded3bf946f (commit)
       via  19ee7ead6be107f50bc51ba47386694546e71ebf (commit)
       via  564200f62f9111609bb95626447a30f57db05ddd (commit)
       via  91d64f90a5b891fc9e79b0f356747ebbef1d3b89 (commit)
      from  d0cfd46c14b94f2c175c3aa116a5014f9e267a2b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c56ae22be9d6dedc095c484d1c8d6469565dd727
Author: Fred Wright <address@hidden>
Date:   Wed Mar 20 16:00:51 2019 -0700

    gegps: Fix typos
    
    The manpage text referred to 'gpsd' where it meant 'gegps'.
    
    The program's stopped message said 'gegpsd'.
    
    TESTED:
    Manpage and stopped message text are now correct.

commit 46bf8df5048ee28ed7161868918a468a93935c9e
Author: Fred Wright <address@hidden>
Date:   Wed Mar 20 15:53:16 2019 -0700

    lcdgps: Fix typo in -V.
    
    TESTED:
    Now shows correct program name in -V output.

commit 9a742334e9867d23dc3660f7ad9e2dded3bf946f
Author: Fred Wright <address@hidden>
Date:   Wed Mar 20 15:41:41 2019 -0700

    gpsrinex: Fix some compiler warnings.
    
    There were two issues here:
    
    1) The initializer for the obs_cnt array needs two levels of brace,
    since it's an array of structs.
    
    2) The obs_cnts array was incorrectly typed as having obs_codes enums
    as its *values*, when they're actually only used for its index.  This
    resulted in a warning about the apparently pointless comparison
    against 99999.
    
    TESTED:
    Ran "build-all check" on OSX 10.9, 10.13, and 10.5 (PPC), as well as
    Ubuntu 14.04.

commit 19ee7ead6be107f50bc51ba47386694546e71ebf
Author: Fred Wright <address@hidden>
Date:   Wed Mar 20 15:01:29 2019 -0700

    Fix shared library installs on OSX.
    
    Shared libraries on OSX need to have their IDs set to their full paths
    in order to get the proper paths into executables.  Ideally, SCons
    would take care of this, but doesn't.  It's necessary to use the OSX
    install_name_tool on an installed library to fix that.
    
    This adds code to do that, verifying that install_name_tool actually
    exists, and falling back to installing without it (the former
    behavior) otherwise.  However, the CheckProg function didn't exist in
    some old versions of SCons, so if it's missing (on OSX), the code just
    assumes that the tool is present and hopes for the best.  The version
    of SCons provided by MacPorts is known to have CheckProg.
    
    TESTED:
    Ran installs on OSX 10.9, 10.13, and 10.5 (PPC), as well as Ubuntu
    14.04.  Verified that the tool is used and has the intended effect
    when present on OSX.  Verified that the install works without using it
    on OSX without it, as well as Linux without it, including when a dummy
    version is present on Linux.  Did *not* test with an old SCons.

commit 564200f62f9111609bb95626447a30f57db05ddd
Author: Fred Wright <address@hidden>
Date:   Wed Mar 20 13:05:10 2019 -0700

    Fix fencepost errors in GPS epoch (mainly comments).
    
    The definition of GPS_EPOCH in gpsd.h is correct, but the comment
    specified the incorrect corresponding date, which is 06-Jan-1980, not
    06-Jan-1981, which isn't even a Sunday.
    
    The century hack in driver_nmea0183.c establishes a 100-year window
    for interpreting two-digit years.  For now, the range 1980-2079 is
    reasonable, given that the GPS epoch is 06-Jan-1980, and the mention
    of wrapping "at" 2080 is consistent with this, but the comment
    incorrectly placed the GPS epoch in 1981 (perhaps due to believing the
    wrong comment in gpsd.h), and the code was written to wrap *after*
    2080, rather than *at* 2080.  This would place the window at
    1981-2080, which would screw up 1980 (admittedly an unlikely case).
    
    This is mostly about not misleading people reading the code than
    actual real-life trouble.
    
    TESTED:
    Existing tests pass.  A test case for a year of "80" would be needed
    to actually verify the fix, though.

commit 91d64f90a5b891fc9e79b0f356747ebbef1d3b89
Author: Fred Wright <address@hidden>
Date:   Wed Mar 20 11:50:55 2019 -0700

    gpsutils: Fix unix_to_iso8601 NaN case.
    
    Since the return type of unix_to_iso8601 is non-const, it's illegal
    to return a pointer to a string constant.  Some compilers report
    a warning for this.  The fix is to copy the string to the provided
    buffer.
    
    It would be nice to add a test case for this, but there doesn't seem
    to be any portable way to get NaN as a constant in C.
    
    TESTED:
    The warning is gone, and the tests still pass.

-----------------------------------------------------------------------

Summary of changes:
 SConstruct        | 18 +++++++++++++++++-
 driver_nmea0183.c |  4 ++--
 gegps             |  2 +-
 gpsd.h            |  2 +-
 gpsrinex.c        |  5 ++---
 gpsutils.c        |  2 +-
 lcdgps.c          |  2 +-
 man/gps.xml       |  2 +-
 8 files changed, 26 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
GPSD



reply via email to

[Prev in Thread] Current Thread [Next in Thread]