[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Use pselect() to reduce wakeups and avoid race co

From: Eric S. Raymond
Subject: Re: [gpsd-dev] [PATCH] Use pselect() to reduce wakeups and avoid race conditions
Date: Sat, 14 Jan 2012 02:03:38 -0500
User-agent: Mutt/1.5.21 (2010-09-15)

Mike Frysinger <address@hidden>:
> neat trick, but i wonder if we even have to bother.  pselect() has been in 
> the 
> Linux kernel (and thus race free) for almost 6 years.  the select() based 
> code, while admittedly racy, isn't that big of a deal -- at worse, the code 
> takes 1 second to respond.  i think this is an acceptable trade off -- 
> install 
> a kernel from the last 6 years, or suck it up ;).

I concur.  It's a tiny race window, the consequences aren't horrible, and
given those circumstances I'd rather keep our code complexity down than
pull fancy tricks like the self-pipe hack.
                <a href="";>Eric S. Raymond</a>

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]