Re: [gpsd-dev] [PATCH] always install the man pages

[Bernd Zeimetz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 02/10/2012 09:41 PM, Mike Frysinger wrote:
> On Friday 10 February 2012 03:28:36 Bernd Zeimetz wrote:
>> On 02/09/2012 11:08 PM, Mike Frysinger wrote:
>>> Since we maintain local copies, don't require xmlto/xsltproc in order
>>> to install them.  This makes packaging simpler.
>> 
>> Your patch doesn't work as manpages are removed when the build directory 
>> is being cleaned. If you want to implement something like that you have 
>> to ensure that manpages are only removed if they were built before.
> 
> my patch works perfectly fine with the release tarballs which is what i'm 
> concerned with.

No. Even with release tarballs it must be possible to clean the build
directory and have a useful source again afterwards. If we allow to use the
shipped manpages, we must not delete them if they were not generated.

> you're right that in the git sense, cleaning everything and 
> building+installing w/out xmlto will result in an error.  i think that
> error method is fine.  attempting to maintain state locally and say "well,
> i just built the man pages and so i know i need to not clean them because i
> had xmlto installed at some point" is a bad idea.
> 
> i could have the logic only rm the man pages if manbuilder is True as that
> is less hacky.
> 
>> (On a sidenote, I still fail to understand whats so hard on installing 
>> the necessary tools to build them).
> 
> if i check out git and try to build that, i have no problem requiring 
> xmlto/etc...  but these should not be required for people
> building+installing releases. -mike


- -- 
 Bernd Zeimetz                            Debian GNU/Linux Developer
 http://bzed.de                                http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJPNjyQAAoJEOs2Fxpv+UNf2IsP/jtxRwYL5C4meqUOKKw6Drg4
YtsdoMZd7oTA4ZCjDQ5GspUQEGTzUqF448T0KwtpsZt9CUbgLLOMrGAdNJScp2QO
U5RcRwUFKZE5MIrKlnzdfBlcaNHoUyzG0KUA4piONSNlTZEPz8Khnk/6T0cllVcd
9/an30THVqELfRPzcgIpoPyHZaDEmmD3UXjdzQDCe6PQ0+J0dxqSenvnz5coHV+q
uz0z8uaWhkm7BKxUBJIqMvpEkkaBwQSjF9hzTSnhl8QHHJwfRWvFqpxfxq8Feyov
tiVBzXnZhUj08VifjCzWmta65akZ7VJt9uh0UiK0fDfRTAwRAIo2JF8pqJ8nS1kp
WCbU5KaMy7kohTSTIMG3ChLh73qKakJZH0vOQJ51ILjhOPfzT28+KRLzGPihQXy8
aG13lCgZrjSFONzHdUn8VdDgdwGUUQ2repipUAEaZmz3eoky6qAczguKqM0UdWWg
dHPeyxLi1jqvq7Nl6a9soFQDtE7o9Tc+7O93PYHkO87m6Kvp8pgaynlpONFP6PtE
ncjCxBpyTEmv6tpvaN+/QfxyX+PP/ralrrbaeR/ZrBCz7Thd/Lzcx7V/sXdoXZmD
+nS+wkNveIzsdElfvXm/UDGBdLw0rmfhIY0et7yYOi7I5tX6xo4TLQcavr6npCDs
A6LQr7BJP3V+22cYaTtH
=ItFn
-----END PGP SIGNATURE-----