[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] json.h, hex.c: 2 potentially "hot" commits

From: Christian Gagneraud
Subject: [gpsd-dev] json.h, hex.c: 2 potentially "hot" commits
Date: Mon, 04 Jun 2012 07:08:30 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120421 Thunderbird/12.0

Hi Eric, all,

I'm close to fix all the bugs unveiled by my live test campaign, but for some of them, I have 2 potentially "hot" commits:
- json.h: Change JSON_VAL_MAX from 120 to 512
This is to allow the parsing long hexdump (data fields), the longest JSON string I saw was 389 characters long - hex.c: gpsd_hexdump(): revert commit 9f6ab53d, that try to text dump instead of hex-dump if the data is "printable", the problem is that lenhex_unpack from ais_jsonc.c expect hex dumps, not hex or text. Trying to get lenhex_unpack guess if it's hex or text sounds dirty to me and is asking for more trouble IMHO.

What do you think about these Eric? Do they seem acceptable for you?


Christian Gagneraud,
Embedded systems engineer.
Techworks Marine
1 Harbour road
Dun Laoghaire
Co. Dublin
Tel: + 353 (0) 1 236 5990

reply via email to

[Prev in Thread] Current Thread [Next in Thread]