[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effec

From: Eric S. Raymond
Subject: Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects
Date: Tue, 5 Jun 2012 12:46:58 -0400
User-agent: Mutt/1.5.21 (2010-09-15)

address@hidden <address@hidden>:
> These 5 patches make modifications to some code that affects other components.
> Scons check passed on each individual commit, so there shouldn't be any 
> regression.
> - The first patch makes gpsdecode honor the unscaled flag, and fix SConstruct
>   so that the tests are not affected.
> - The second one makes gpsd_hexdump() always dump in hexadecimal form (no more
>   "maybe text, maybe hex" behaviour)
> - The third one increase the maximum json value length (AIS can produce "very"
>   long strings)
> - The forth one adds a new talker ID: BS, which is used by some AIS
>   basestation
> - The last one adds a simple script that can be used to check for JSON
>   validity

Are these applied already?  The all look good except the change to
hexdump behavior.  It's written that way for a reason - otherwise we get
logfiles from NMEA devices that are unnecessarily obfuscated.  
                <a href="";>Eric S. Raymond</a>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]