[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] Moving nmea2000 open function out of libgpsd_core.c

From: Gary E. Miller
Subject: Re: [gpsd-dev] Moving nmea2000 open function out of libgpsd_core.c
Date: Wed, 6 Jun 2012 12:46:27 -0700

Yo address@hidden

On Wed, 06 Jun 2012 20:19:17 +0200
"address@hidden" <address@hidden> wrote:

>       1.) does it make sense to move most of the nmea2000 code out
> of the libgpsd_core.c and into driver_nmea2000.c, at the cost of an
> driver_nmea2000.h file? 

Makes sense to me.

>       2.) I may be a lean approach to handle every device on the a
> nmea2000 bus as an own device, and open the device automatic, when it
> is detected. My idea is to call  add_device() with a string like
> "nmea2000://can0:14".  14 is in this example the device id on the
> nmea2000 bus. The cost is, that "add_device" can no longer be a static
> function. 

We already have a lot of GPS driver specific functions handled through
pointers in the device table.  You could maybe grow that sort of
mechanism to your needs.

Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97701
        address@hidden  Tel:+1(541)382-8588

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]