[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 2/3] set a socket timeout for slow

From: Christian Gagneraud
Subject: Re: [gpsd-dev] [PATCH 2/3] set a socket timeout for slow servers.
Date: Fri, 01 Nov 2013 11:38:35 +1300
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0

On 01/11/13 11:32, Beat Bolli wrote:
On 31.10.13 23:16, Greg Troxel wrote:

Beat Bolli <address@hidden> writes:

I have problems connecting to, and setting a socket
timeout at least doesn't block the build process.


It's a bug if the build tries to fetch anything by default.

The fetch is conditional:

if 'dev' in gpsd_version or not os.path.exists('leapseconds.cache'):

You think the first term should be removed?

This is the "quick and dirty" fix I did locally yesterday, I don't like when a build require an internet connection this way. Maybe it could be mitigated with a test like "if leapseconds.cache is older than X month/week", or make it an explicit scons target like "scons leapseconds.cache"

My 2 cents,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]