[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH RESEND] libgps.h: Fix linkage problem

From: Michal Privoznik
Subject: Re: [gpsd-dev] [PATCH RESEND] libgps.h: Fix linkage problem
Date: Fri, 05 Dec 2014 08:57:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

On 26.11.2014 11:59, Michal Privoznik wrote:
On 19.11.2014 16:29, Greg Troxel wrote:

Greg Troxel <address@hidden> writes:

Michal Privoznik <address@hidden> writes:

diff --git a/libgps.h b/libgps.h
index f773188..914c4df 100644
--- a/libgps.h
+++ b/libgps.h
@@ -10,6 +10,9 @@
  #define SHM_PSEUDO_FD    -1
  #define DBUS_PSEUDO_FD    -2

+#ifdef __cplusplus
+extern "C" {
  extern int gps_sock_open(/address@hidden@*/const char *, 
char *,
                /address@hidden@*/struct gps_data_t *);

I guess the real question is whether libgps.h should have C++ guards
like that or if it's wrong to include it without extern "C" from a C++

Looking around, it seems that it's common practice to have guards in
headers.  I'm not esr and hence not going to merge this, but I would be
inclined to put the guards around the entire file to mitigate issues
 From other changes.

But either way, this fix is needed.

So can you merge it please? It's a build breaker after all.


Ping? Or is gpsd dead upstream?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]