Re: [gpsd-dev] [PATCH] Clean up code, now that it works.

[Sanjeev Gupta]

On Sun, Mar 29, 2015 at 11:06 AM, Chris Kuethe <address@hidden> wrote:

I think the right way to do copyrights is just to add a line of the form

Copyright (C) YYYY[,YYYY] Name <email>

For each contributor, listing the years in which substantial
contributions have been made. Clearly, I haven't touched that script
in years, and in your case "Copyright (c) 2015 Sanjeev Gupta
<address@hidden>" should be sufficient.

I had put that in, but an email from Gary made me think that it was overkill.  My changes are neither novel nor original, I think the heart of skyview.php is the calculations, and I have been careful not to mess with those.

 

This is my first PHP program in years, and the first time I have used a PHP array.  The entire development should have taken 10 mins, it took 6 hours as I learnt PHP (and JSON) along the way.

Small nit: is there some reason you're changing the comment format? If
you're doing it to unify the code style could you fix all of that in
one change, and all the logic in a separate change?

The reason for the two comment styles was deliberate: your comments have been retained using "#", mine are with a "//".  As I said, I have only modified the reading and parsing of the data, not the use and plot.

In a few years, Eric will announce the GPSD-NG++ protocol, which will have a REST-ful API talking to a MongoDB implementation in gpsd; at that time someone can parse and gut out the parts commented with the "//" to keep the program useful.

Chris, I think your skyview.php is still useful, here are two examples from my office, looking up a shaft:
http://203.123.48.219/sky1.png
http://203.123.48.219/sky.png

--
Sanjeev Gupta
+65 98551208     http://www.linkedin.com/in/ghane