[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH] Fix build against musl libc
|
From: |
Gary E. Miller |
|
Subject: |
Re: [gpsd-dev] [PATCH] Fix build against musl libc |
|
Date: |
Tue, 23 Jun 2015 10:48:38 -0700 |
Yo Baruch!
On Tue, 23 Jun 2015 09:12:01 +0300
Baruch Siach <address@hidden> wrote:
> musl does not include sys/ttydefaults.h from sys/termios.h. Include it
> explicitly.
Hmm.
What is 'musl'?
Why do you need <sys/ttydefaults.h> ? No other port needs it.
How common is <sys/ttydefaults.h> ? It is not POSIX-1:2001 (gpsd baseline).
Can we really always expect it to be present?
We'll need a test to see when we need this file and if it exists in the
current system.
So with a little more info we can fix this for you.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1(541)382-8588
On Tue, 23 Jun 2015 09:12:01 +0300
Baruch Siach <address@hidden> wrote:
> musl does not include sys/ttydefaults.h from sys/termios.h. Include it
> explicitly.
>
> Fixes build failures like:
>
> gpsmon.o: In function `main':
> gpsmon.c:(.text.startup+0x8f4): undefined reference to `CTRL'
> ---
> gpsmon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gpsmon.c b/gpsmon.c
> index c3001c865821..0ccf74110b5a 100644
> --- a/gpsmon.c
> +++ b/gpsmon.c
> @@ -20,6 +20,7 @@
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <sys/select.h>
> +#include <sys/ttydefaults.h>
> #include <fcntl.h>
> #include <unistd.h>
>
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1(541)382-8588
pgplzXCLkBOSO.pgp
Description: OpenPGP digital signature